[incubator-uniffle] branch master updated: Fix incorrect log format strings (#220)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 20aa41d0 Fix incorrect log format strings (#220)
20aa41d0 is described below

commit 20aa41d0a4eb843269feab88cd453330a28ba0d3
Author: Kaijie Chen <ck...@apache.org>
AuthorDate: Thu Sep 15 18:43:18 2022 +0800

    Fix incorrect log format strings (#220)
    
    ### What changes were proposed in this pull request?
    
    Fix incorrect log format strings.
    
    ### Why are the changes needed?
    
    SLF4J use `{}` as placeholder in format strings.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    CI.
---
 .../apache/uniffle/coordinator/AppBalanceSelectStorageStrategy.java   | 4 ++--
 .../uniffle/coordinator/LowestIOSampleCostSelectStorageStrategy.java  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/coordinator/src/main/java/org/apache/uniffle/coordinator/AppBalanceSelectStorageStrategy.java b/coordinator/src/main/java/org/apache/uniffle/coordinator/AppBalanceSelectStorageStrategy.java
index c42da449..b77c7f93 100644
--- a/coordinator/src/main/java/org/apache/uniffle/coordinator/AppBalanceSelectStorageStrategy.java
+++ b/coordinator/src/main/java/org/apache/uniffle/coordinator/AppBalanceSelectStorageStrategy.java
@@ -90,7 +90,7 @@ public class AppBalanceSelectStorageStrategy implements SelectStorageStrategy {
     } else {
       // it may be happened when assignment remote storage
       // and refresh remote storage at the same time
-      LOG.warn("Remote storage path lost during assignment: %s doesn't exist, reset it to 1",
+      LOG.warn("Remote storage path lost during assignment: {} doesn't exist, reset it to 1",
           remoteStoragePath);
       remoteStoragePathCounter.put(remoteStoragePath, new RankValue(1));
     }
@@ -104,7 +104,7 @@ public class AppBalanceSelectStorageStrategy implements SelectStorageStrategy {
       if (atomic != null) {
         double count = atomic.getAppNum().decrementAndGet();
         if (count < 0) {
-          LOG.warn("Unexpected counter for remote storage: %s, which is %i, reset to 0",
+          LOG.warn("Unexpected counter for remote storage: {}, which is {}, reset to 0",
               storagePath, count);
           atomic.getAppNum().set(0);
         }
diff --git a/coordinator/src/main/java/org/apache/uniffle/coordinator/LowestIOSampleCostSelectStorageStrategy.java b/coordinator/src/main/java/org/apache/uniffle/coordinator/LowestIOSampleCostSelectStorageStrategy.java
index 96147b8e..f55e04ce 100644
--- a/coordinator/src/main/java/org/apache/uniffle/coordinator/LowestIOSampleCostSelectStorageStrategy.java
+++ b/coordinator/src/main/java/org/apache/uniffle/coordinator/LowestIOSampleCostSelectStorageStrategy.java
@@ -177,7 +177,7 @@ public class LowestIOSampleCostSelectStorageStrategy implements SelectStorageStr
       remoteStoragePathRankValue.put(remoteStoragePath, new RankValue(1));
       // it may be happened when assignment remote storage
       // and refresh remote storage at the same time
-      LOG.warn("Remote storage path lost during assignment: %s doesn't exist, "
+      LOG.warn("Remote storage path lost during assignment: {} doesn't exist, "
           + "reset the rank value to 0 and app size to 1.", remoteStoragePath);
     }
   }
@@ -190,7 +190,7 @@ public class LowestIOSampleCostSelectStorageStrategy implements SelectStorageStr
       if (atomic != null) {
         double count = atomic.getAppNum().decrementAndGet();
         if (count < 0) {
-          LOG.warn("Unexpected counter for remote storage: %s, which is %i, reset to 0",
+          LOG.warn("Unexpected counter for remote storage: {}, which is {}, reset to 0",
               storagePath, count);
           atomic.getAppNum().set(0);
         }