[jira] [Commented] (FLINK-31324) Broken SingleThreadFetcherManager constructor API

["Yun Tang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-31324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696457#comment-17696457 ] 

Yun Tang commented on FLINK-31324:
----------------------------------

cc [~jark] [~mxm]

> Broken SingleThreadFetcherManager constructor API
> -------------------------------------------------
>
>                 Key: FLINK-31324
>                 URL: https://issues.apache.org/jira/browse/FLINK-31324
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Parent
>            Reporter: Yun Tang
>            Assignee: Yun Tang
>            Priority: Blocker
>             Fix For: 1.17.0
>
>
> FLINK-28853 changed the default constructor of {{SingleThreadFetcherManager}}. Though the {{SingleThreadFetcherManager}} is annotated as {{Internal}}, it actually acts as some-degree public API, which is widely used in many connector projects:
> [flink-cdc-connector|https://github.com/ververica/flink-cdc-connectors/blob/release-2.3.0/flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReader.java#L93], [flink-connector-mongodb|https://github.com/apache/flink-connector-mongodb/blob/main/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/MongoSourceReader.java#L58] and so on.
> Once flink-1.17 is released, all these existing connectors are broken and cannot be used in new release version. Thus, I suggest to make the original SingleThreadFetcherManager constructor as depreacted instead of removing it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)