You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/08/13 20:36:52 UTC

[GitHub] [incubator-tvm] mbrookhart removed a comment on issue #6263: #4312 broke Huggingface BERT ONNX import

mbrookhart removed a comment on issue #6263:
URL: https://github.com/apache/incubator-tvm/issues/6263#issuecomment-673671138


   The onnx importer was casting the value to int32_t, leading to the -1 through overflow. If I change the importer to use int64_t, it rounds to zero when we convert the constant int64 input into an Array<Integer>. There's an intermediate double value that can't properly represent int64_t max.
   
   @lixiaoquan I think I just need to split this op into static and dynamic cases. This is very much related to some of the work you're doing in #6024. Would you prefer I wait until that is merged?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org