You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Si Chen (JIRA)" <ji...@apache.org> on 2007/10/06 03:05:50 UTC
[jira] Created: (OFBIZ-1318) screen widget show where code came
from in html
screen widget show where code came from in html
-----------------------------------------------
Key: OFBIZ-1318
URL: https://issues.apache.org/jira/browse/OFBIZ-1318
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Si Chen
This should help debugging a lot:
The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
<!-- Begin XXXX.Forms.xml#FormA -->
<!-- End XXXX.Forms.xml#FormA -->
Similarly, if html-template is called it could put into HTML:
<!-- Begin applications/XXX/x.ftl -->
<!-- End applications/XXX/x.ftl -->
etc. etc.
I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541633 ]
Adrian Crum commented on OFBIZ-1318:
------------------------------------
Jacques,
I was thinking we could do that in the Example component only. From my perspective, you would want the default to be OFF, then turn it ON when you're trying to debug HTML.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: (was: widget_boundary_comments.patch)
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1318:
--------------------------------------
Assignee: Jacques Le Roux
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: (was: widget_boundary_comments.patch)
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
Updated patch to latest SVN.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
Improved patch - now accepts widget.verbose property in debug.properties.
David,
Just to clarify - the original behavior has been preserved. Boundary comments are still enabled with widgetVerbose set true in the parameters Map.
Jacques,
This patch includes the Example component context parameter in web.xml.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534062 ]
Adrian Crum commented on OFBIZ-1318:
------------------------------------
Si,
I'm confused. What does "deprecated methods of the old parameter signatures" mean?
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532807 ]
Si Chen commented on OFBIZ-1318:
--------------------------------
So, anyway, is anybody opposed to this?
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541630 ]
Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------
Adrian,
To make this useful feature easier to use I propose to put
<context-param>
<param-name>widgetVerbose</param-name>
<param-value>false</param-value>
<description>Set to true to enables widget boundary comments. See JavaDoc for use in screen widget </description>
</context-param>
in each web.xml files. If nobody see problems with that I will do it and commit the whole soon
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541638 ]
Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------
Adrian,
Yes I agree, Example should be sufficient, shoulf be OFF of course. We may also put some information in Confluence as looking in web.xml or javaDoc is not obvious. Not sure on which page yet (any ideas welcome), then I will put a link from "my" tips :o)
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533140 ]
Adrian Crum commented on OFBIZ-1318:
------------------------------------
Si,
I looked at that capability back when I was refactoring the UI. The existing comments that Jacques mentioned were put there by me. At the time David had commented about the existing capability to turn on the comments via a parameter, so I checked into it. I found that the code David is referring to needed work - because the commenting was done by the model classes, not the HTML rendering classes. I had planned on reworking the screen widgets to move that code to the HTML rendering classes, but I ran out of time.
Anyways, I'll vote for this. I agree it would greatly benefit development. I can lend a hand if you'd like.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532815 ]
Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------
I just worked on widget, it seems to me (not sure) that no parameters is needed (it's by default).
Look for
buffer.append("<!-- begin form widget -->");
string in *.java
For the moment it's not as complete as what Si propose. This could be easily enhanced... I vote for !
For me it does not need to be VERBOSE, as it's right now it's ok, just extending should be sufficient
My 2 cents
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541660 ]
Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------
I would prefer debug.properties too.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
Si,
I am attaching a basic patch for you to review. I moved the boundary comment code to the rendering classes. I also cleaned up a few things and fixed a bug I ran into while working on it.
The rendered comments don't include the location#name syntax you're looking for because the rendering classes have no references to the model classes that created them. I could develop this further to enable that capability, but that would require refactoring the widget interfaces.
HTML comments are enabled with the "widgetVerbose" parameter set to true.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533911 ]
Si Chen commented on OFBIZ-1318:
--------------------------------
Wow, this is interesting. As far as I'm concerned, it'd be nice to provide deprecated methods of the old parameter signatures, but otherwise it looks OK.
What does everybody else think?
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
Updated patch to latest SVN.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533198 ]
Si Chen commented on OFBIZ-1318:
--------------------------------
Yea, Adrian, if you have some time to work on it it'd be great!
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: (was: widget_boundary_comments.patch)
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532808 ]
David E. Jones commented on OFBIZ-1318:
---------------------------------------
there is already some stuff like this in the screen widget, activated by passing a special parameter
I never remember what that parameter is, but looking at the screen widget code you can find it pretty easily
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: (was: widget_boundary_comments.patch)
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541652 ]
David E. Jones commented on OFBIZ-1318:
---------------------------------------
Do we really want to configure this through web.xml?
What about when a screen or form or whatever is rendered in a non-web context and there is no web.xml?
In the past this happened when passing in a special parameter, so it just had to be in the parameters Map for the screen, but admittedly that may not be the best choice.
How about a property in debug.properties, like piggy-backing on verbose or info? Info is usually on during development only, or when debugging production servers, and that might be a good option.
Other ideas?
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: (was: widget_boundary_comments.patch)
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
Final version attached.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1318) screen widget show where code came from
in html
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1318.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Adrian,
Your patch is in trunk revision: 594042.
I just wondered if we should not use the compressHTML by default (ON) from a property in general.properties ?
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
Improved patch. All comments appear as requested.
I didn't have to refactor anything - minimal changes were made.
If this patch is acceptable, let me know and I will flesh out the javadocs, then I will submit a final version.
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1318) screen widget show where code came
from in html
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1318:
-------------------------------
Attachment: widget_boundary_comments.patch
> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.