You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:28:29 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request, #4498: Revert PR4025 due to changes in compile time constants.
neilcsmith-net opened a new pull request, #4498:
URL: https://github.com/apache/netbeans/pull/4498
Straight revert of #4025 due to breaking changes in compile time constants.
cc @lkishalmi @mbien alternative option to revert rather than patch. Some of the other changes could then be looked at and reviewed again in master for NB16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4498: Revert PR4025 due to changes in compile time constants.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4498:
URL: https://github.com/apache/netbeans/pull/4498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #4498: Revert PR4025 due to changes in compile time constants.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #4498:
URL: https://github.com/apache/netbeans/pull/4498#issuecomment-1213073948
Good morning folks. Hey @neilcsmith-net , @mbien can I get a clearer picture of what is broken? The bug says "breaking changes" but it's not clear to me what is broken.. Clearly the platforms are dead, so maybe I can easily fix it instead of doing a revert..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4498: Revert PR4025 due to changes in compile time constants.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4498:
URL: https://github.com/apache/netbeans/pull/4498#issuecomment-1213133786
I'm not sure it's "can inline" but rather "must inline". eg. from JLS "If a final field is initialized to a constant expression in the field declaration, ... uses of that final field are replaced at compile time with the value of the [constant expression](https://docs.oracle.com/javase/specs/jls/se14/html/jls-15.html#jls-15.29)".
@BradWalker this means that the value those fields are assigned should not change. Code (eg. third-party plugins) compiled against older versions of the IDE could have different values. The masks are also constant expressions. It's a binary incompatible change.
The values are also in the API signature files - I saw it initially when generating those for NB15. Check the diff in #4487 The tests should really have not passed with the changes.
I'm of the opinion that revert, fix, re-apply is sometimes a better strategy for handling breaking changes. Obviously here the re-apply would be in master for NB16 though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4498: Revert PR4025 due to changes in compile time constants.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4498:
URL: https://github.com/apache/netbeans/pull/4498#issuecomment-1213080559
@BradWalker values of public final primitive fields can't change. If they do it will break existing code since compilers can inline those sometimes. It would be also safer to simply keep all public fields and deprecate them. see #4497 and dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a diff in pull request #4498: Revert PR4025 due to changes in compile time constants.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on code in PR #4498:
URL: https://github.com/apache/netbeans/pull/4498#discussion_r950657498
##########
platform/o.n.swing.tabcontrol/beanstubs/org/openide/util/Utilities.java:
##########
@@ -56,8 +56,12 @@ private Utilities() {}
/** Operating system is Windows NT. */
public static final int OS_WINNT = 1 << 0;
+ /** Operating system is Windows 95. */
+ public static final int OS_WIN95 = OS_WINNT << 1;
Review Comment:
Thank you for restoring the previous API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists