You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/30 03:09:10 UTC
[GitHub] [iotdb] THUMarkLau opened a new pull request, #7490: [IOTDB-4554] Start compaction only when IoTDB is fully recovered
THUMarkLau opened a new pull request, #7490:
URL: https://github.com/apache/iotdb/pull/7490
See [IOTDB-4554](https://issues.apache.org/jira/browse/IOTDB-4554).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #7490: [IOTDB-4554] Start compaction only when IoTDB is fully recovered
Posted by GitBox <gi...@apache.org>.
xingtanzjr merged PR #7490:
URL: https://github.com/apache/iotdb/pull/7490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on a diff in pull request #7490: [IOTDB-4554] Start compaction only when IoTDB is fully recovered
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on code in PR #7490:
URL: https://github.com/apache/iotdb/pull/7490#discussion_r984178493
##########
server/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -250,6 +252,7 @@ private void active() throws StartupException {
logger.error("Meet error while starting up.", e);
throw new StartupException("Error in activating IoTDB DataNode.");
}
+ activated = true;
Review Comment:
It seems that activated cannot turn false when deactivate the datanode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #7490: [IOTDB-4554] Start compaction only when IoTDB is fully recovered
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on code in PR #7490:
URL: https://github.com/apache/iotdb/pull/7490#discussion_r984391502
##########
server/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -316,6 +315,7 @@ private void setUp() throws StartupException, QueryProcessException {
registerManager.register(RegionMigrateService.getInstance());
registerManager.register(MetricService.getInstance());
+ registerManager.register(CompactionTaskManager.getInstance());
Review Comment:
As we change the sequence of invoking `CompactionTaskManager.getInstance()`, why do we need to add the variable `init` inside the class ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a diff in pull request #7490: [IOTDB-4554] Start compaction only when IoTDB is fully recovered
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on code in PR #7490:
URL: https://github.com/apache/iotdb/pull/7490#discussion_r984228387
##########
server/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -250,6 +252,7 @@ private void active() throws StartupException {
logger.error("Meet error while starting up.", e);
throw new StartupException("Error in activating IoTDB DataNode.");
}
+ activated = true;
Review Comment:
Fixed, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org