You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lucarosellini <gi...@git.apache.org> on 2015/06/01 14:24:38 UTC
[GitHub] spark pull request: [SPARK-4782] Add inferSchema support for RDD[M...
GitHub user lucarosellini opened a pull request:
https://github.com/apache/spark/pull/6554
[SPARK-4782] Add inferSchema support for RDD[Map[String, Any]]
In this PR we added a generic inferSchema method to allow schema infer for an RDD of a generic type T for which the user provides a mapping function from RDD[T] => RDD[Map[String,Any]]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keedio/spark SPARK-4782
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6554
----
commit 65b44fa3219538265055285cee072267af0a7b85
Author: Luca Rosellini <lu...@gmail.com>
Date: 2015-06-01T12:22:38Z
[SPARK-4782] Added generic inferSchema method to allow schema infer for an RDD of a generic type T for which the user provides a mapping function from RDD[T] => RDD[Map[String,Any]]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4782] Add inferSchema support for RDD[M...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6554#issuecomment-107422132
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4782] Add inferSchema support for RDD[M...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6554#issuecomment-137567023
Thanks for working on this @lucarosellini. Can we close this issue until you have time to bring it up to data and address the comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4782] Add inferSchema support for RDD[M...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4782] Add inferSchema support for RDD[M...
Posted by lucarosellini <gi...@git.apache.org>.
Github user lucarosellini commented on the pull request:
https://github.com/apache/spark/pull/6554#issuecomment-137658203
@marmbrus sure, go ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4782] Add inferSchema support for RDD[M...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6554#issuecomment-107572172
I don't know anything about this feature or patch, but as an outside observer I _can_ say that this needs tests or at least _a_ test to make sure that this feature doesn't get broken by future changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org