You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2020/12/06 01:25:34 UTC

[Bug 64959] New: PackagePart#flush is unused

https://bz.apache.org/bugzilla/show_bug.cgi?id=64959

            Bug ID: 64959
           Summary: PackagePart#flush is unused
           Product: POI
           Version: 4.1.2-FINAL
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: OPC
          Assignee: dev@poi.apache.org
          Reporter: marius@volkhart.com
  Target Milestone: ---

This method is never called by the POI code, and none of the built-in
implementations have meaningful implementation of the method.

PackagePropertiesPart#flush() was called in one location, but as the
implementation is empty, the call is unnecessary.

There's no bug here, rather, there's just code that is essentially dead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 64959] PackagePart#flush is unused

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64959

--- Comment #1 from marius@volkhart.com ---
PR available https://github.com/apache/poi/pull/202

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 64959] PackagePart#flush is unused

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64959

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 64959] [PATCH] PackagePart#flush is unused

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64959

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEEDINFO                    |RESOLVED

--- Comment #2 from PJ Fanning <fa...@yahoo.com> ---
I don't think we want to implement this - Marius closed the PR - Marius, please
feel free to reopen if you feel strongly about this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 64959] [PATCH] PackagePart#flush is unused

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64959

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 64959] [PATCH] PackagePart#flush is unused

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64959

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PackagePart#flush is unused |[PATCH] PackagePart#flush
                   |                            |is unused

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org