You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2024/03/20 13:39:34 UTC

[PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

oscerd opened a new pull request, #13550:
URL: https://github.com/apache/camel/pull/13550

   … embeddings in qdrant objects
   
   # Description
   
   <!--
   - Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   -->
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
   
   <!--
   You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.

oscerd commented on code in PR #13550:
URL: https://github.com/apache/camel/pull/13550#discussion_r1532099857


##########
components/camel-qdrant/src/main/java/org/apache/camel/component/qdrant/transform/QdrantEmbeddingsDataTypeTransformer.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.camel.component.qdrant.transform;
+
+import java.util.UUID;
+
+import dev.langchain4j.data.embedding.Embedding;
+import dev.langchain4j.data.segment.TextSegment;
+import io.qdrant.client.PointIdFactory;
+import io.qdrant.client.ValueFactory;
+import io.qdrant.client.VectorsFactory;
+import io.qdrant.client.grpc.Points;
+import org.apache.camel.Message;
+import org.apache.camel.component.qdrant.Qdrant;
+import org.apache.camel.spi.DataType;
+import org.apache.camel.spi.DataTypeTransformer;
+import org.apache.camel.spi.Transformer;
+
+/**
+ * Maps a Langchain Embeddings to a Qdrant PointStruct to write an embeddings vector on a Qdrant Database.
+ */
+@DataTypeTransformer(name = "qdrant:embeddings",
+                     description = "Prepares the message to become an object writable by Qdrant component")
+public class QdrantEmbeddingsDataTypeTransformer extends Transformer {
+
+    @Override
+    public void transform(Message message, DataType fromType, DataType toType) {
+        Embedding embedding = message.getHeader("CamelLangchainEmbeddingsVector", Embedding.class);

Review Comment:
   @lburgazzoli this is needed to avoid circular dependencies between langchain embeddings and qdrant components.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.

lburgazzoli commented on code in PR #13550:
URL: https://github.com/apache/camel/pull/13550#discussion_r1532101778


##########
components/camel-qdrant/src/main/java/org/apache/camel/component/qdrant/Qdrant.java:
##########
@@ -53,5 +53,8 @@ public static class Headers {
 
         @Metadata(description = "The number of elements.", javaType = "int")
         public static final String SIZE = "CamelQdrantSize";
+
+        @Metadata(description = "The point id to use for operation.", javaType = "int")
+        public static final String POINT_ID = "CamelQdrantSize";

Review Comment:
   The header name seems to be wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.

oscerd merged PR #13550:
URL: https://github.com/apache/camel/pull/13550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.

oscerd commented on code in PR #13550:
URL: https://github.com/apache/camel/pull/13550#discussion_r1532110103


##########
components/camel-qdrant/src/main/java/org/apache/camel/component/qdrant/Qdrant.java:
##########
@@ -53,5 +53,8 @@ public static class Headers {
 
         @Metadata(description = "The number of elements.", javaType = "int")
         public static final String SIZE = "CamelQdrantSize";
+
+        @Metadata(description = "The point id to use for operation.", javaType = "int")
+        public static final String POINT_ID = "CamelQdrantSize";

Review Comment:
   Fixing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #13550:
URL: https://github.com/apache/camel/pull/13550#issuecomment-2009630402

   :robot: The Apache Camel test robot will run the tests for you :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #13550:
URL: https://github.com/apache/camel/pull/13550#issuecomment-2009591516

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.

oscerd commented on PR #13550:
URL: https://github.com/apache/camel/pull/13550#issuecomment-2009628285

   /component-test ai qdrant


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-20587 - Camel-Qdrant: Add a datatype for transforming langchain… [camel]

Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.

zbendhiba commented on PR #13550:
URL: https://github.com/apache/camel/pull/13550#issuecomment-2017636708

   @oscerd Nice !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org