[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #137: Document DefaultConfigurator actual behaviour

[GitBox <gi...@apache.org>]

rm5248 commented on code in PR #137:
URL: https://github.com/apache/logging-log4cxx/pull/137#discussion_r985090285


##########
src/main/include/log4cxx/defaultconfigurator.h:
##########
@@ -39,19 +35,39 @@ class LOG4CXX_EXPORT DefaultConfigurator
 
 	public:
 		/**
-		Add a ConsoleAppender that uses PatternLayout
-		using the PatternLayout#TTCC_CONVERSION_PATTERN and
-		prints to <code>stdout</code> to the root logger.*/
-		static void configure(log4cxx::spi::LoggerRepositoryPtr repository);
+		Configure \c repository.
+
+		If the configuration file name has not been provided by a call to setConfigurationFileName(),
+		the environment variables 'LOG4CXX_CONFIGURATION' and 'log4j.configuration' are examined.
+
+		If the configuration file name has not been provided by any of the previous approaches
+		the current directory is examined for a file named either
+		"log4cxx.xml", "log4cxx.properties", "log4j.xml" or "log4j.properties".

Review Comment:
   what happens if this fails?  Does it still fall back to the old way of using the `PatternLayout`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org