You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/23 02:50:49 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4894: Opt curator-

kimmking opened a new pull request #4894: Opt curator-
URL: https://github.com/apache/incubator-shardingsphere/pull/4894
 
 
   Fixes #4773 .
   
   Changes proposed in this pull request:
   - 1、Remove testserver renewing and keep only one server during this test class running
   - 2、Use final CenterRepository "client" instead of clientA, keep only one client

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4894: Opt curator-client in unit test

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4894: Opt curator-client in unit test 
URL: https://github.com/apache/incubator-shardingsphere/pull/4894#issuecomment-602363724
 
 
   ## Pull Request Test Coverage Report for [Build 2212](https://coveralls.io/builds/29539094)
   
   * **1** of **2**   **(50.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.07%**) to **58.244%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/29539094/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L255) | 1 | 2 | 50.0%
   <!-- | **Total:** | **1** | **2** | **50.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29539094/badge)](https://coveralls.io/builds/29539094) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  0.07% |
   | Covered Lines: | 11880 |
   | Relevant Lines: | 20397 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4894: Opt curator-client in unit test

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4894: Opt curator-client in unit test 
URL: https://github.com/apache/incubator-shardingsphere/pull/4894#issuecomment-602363724
 
 
   ## Pull Request Test Coverage Report for [Build 10484](https://coveralls.io/builds/29539118)
   
   * **1** of **2**   **(50.0%)**  changed or added relevant lines in **1** file are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.007%**) to **58.165%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/29539118/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L255) | 1 | 2 | 50.0%
   <!-- | **Total:** | **1** | **2** | **50.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29539118/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29539118/badge)](https://coveralls.io/builds/29539118) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  -0.007% |
   | Covered Lines: | 11864 |
   | Relevant Lines: | 20397 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4894: Opt curator-client in unit test

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4894: Opt curator-client in unit test 
URL: https://github.com/apache/incubator-shardingsphere/pull/4894#issuecomment-602363676
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=h1) Report
   > Merging [#4894](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6885ec6c8a060ffc1dd8d87adbbdda1e3530d02f&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4894      +/-   ##
   ============================================
   - Coverage     54.67%   54.65%   -0.03%     
   + Complexity      436      434       -2     
   ============================================
     Files          1138     1138              
     Lines         20412    20397      -15     
     Branches       3752     3749       -3     
   ============================================
   - Hits          11161    11148      -13     
   + Misses         8547     8545       -2     
     Partials        704      704              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckNlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `65.76% <50.00%> (-0.05%)` | `24.00 <1.00> (-2.00)` | |
   | [...rdingjdbc/jdbc/core/statement/ShadowStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYWRvd1N0YXRlbWVudC5qYXZh) | `62.50% <0.00%> (-1.14%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/jdbc/core/statement/ShadowPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYWRvd1ByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `40.36% <0.00%> (-1.08%)` | `0.00% <0.00%> (ø%)` | |
   | [...dingjdbc/jdbc/core/statement/EncryptStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRTdGF0ZW1lbnQuamF2YQ==) | `58.22% <0.00%> (-1.04%)` | `0.00% <0.00%> (ø%)` | |
   | [.../jdbc/core/statement/EncryptPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `79.61% <0.00%> (-0.39%)` | `0.00% <0.00%> (ø%)` | |
   | [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `85.26% <0.00%> (-0.16%)` | `1.00% <0.00%> (ø%)` | |
   | [.../shardingsphere/core/shard/BaseShardingEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWVudHJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jb3JlL3NoYXJkL0Jhc2VTaGFyZGluZ0VuZ2luZS5qYXZh) | `86.95% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...dingsphere/underlying/rewrite/SQLRewriteEntry.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvU1FMUmV3cml0ZUVudHJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=footer). Last update [6885ec6...f058c0e](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4894: Opt curator-client in unit test

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4894: Opt curator-client in unit test 
URL: https://github.com/apache/incubator-shardingsphere/pull/4894
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services