You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kayx23 (via GitHub)" <gi...@apache.org> on 2025/09/05 10:26:31 UTC
[PR] docs: add missing wasm parameters [apisix-helm-chart]
kayx23 opened a new pull request, #871:
URL: https://github.com/apache/apisix-helm-chart/pull/871
Wasm's `priority`, `file`, and `http_request_phase` were previously documented but got removed in https://github.com/apache/apisix-helm-chart/pull/415 which switched to using `helm-docs` to generate the docs.
The missed configuration could lead to:
<img width="826" height="97" alt="image" src="https://github.com/user-attachments/assets/9e03628a-aed5-4354-b04f-3bb96547b587" />
This PR adds these parameters back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add missing wasm parameters [apisix-helm-chart]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #871:
URL: https://github.com/apache/apisix-helm-chart/pull/871#issuecomment-3396590615
These parameters are indeed missing from the docs but the level updated in this PR seems wrong.
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml#L297-L301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add missing wasm parameters [apisix-helm-chart]
Posted by "nic-6443 (via GitHub)" <gi...@apache.org>.
nic-6443 commented on code in PR #871:
URL: https://github.com/apache/apisix-helm-chart/pull/871#discussion_r3141395681
##########
charts/apisix/values.yaml:
##########
@@ -554,9 +554,16 @@ apisix:
cmd: ["/path/to/apisix-plugin-runner/runner", "run"]
wasm:
- # -- Enable Wasm Plugins. See [wasm plugin](https://apisix.apache.org/docs/apisix/next/wasm/)
+ # -- Enable Wasm Plugins. See [wasm plugin](https://apisix.apache.org/docs/apisix/next/wasm/).
enabled: false
+ # -- Set Wasm plugin name.
plugins: []
+ # -- Set wasm plugin priority.
+ priority: 7999
+ # -- Set path to Wasm plugin.
+ file: ""
Review Comment:
`priority`, `file`, and `http_request_phase` are per-plugin properties in APISIX's config, not top-level wasm settings. The existing configmap template just does `toYaml .Values.apisix.wasm.plugins`, so these top-level values won't be used in the generated config at all.
The correct structure should have these as fields within each plugin entry:
```yaml
wasm:
enabled: false
plugins:
- name: "example-plugin"
priority: 7999
file: "/path/to/plugin.wasm"
http_request_phase: "rewrite"
```
As-is, setting `apisix.wasm.priority` or `apisix.wasm.file` would have no effect on the rendered config. The docs should show the correct per-plugin structure instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org