You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ro...@apache.org on 2023/11/29 15:28:54 UTC
(pinot) branch master updated: [multistage][cleanup] remove some unused rules (#12052)
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 37270f749c [multistage][cleanup] remove some unused rules (#12052)
37270f749c is described below
commit 37270f749c9ac3fcd652bb97162c84e0a3d38543
Author: Rong Rong <ro...@apache.org>
AuthorDate: Wed Nov 29 07:28:46 2023 -0800
[multistage][cleanup] remove some unused rules (#12052)
* cleanup some unused rules
---------
Co-authored-by: Rong Rong <ro...@startree.ai>
---
.../apache/calcite/rel/rules/PinotQueryRuleSets.java | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java b/pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java
index b73a2b62b2..9dc29757f9 100644
--- a/pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java
+++ b/pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java
@@ -49,12 +49,9 @@ public class PinotQueryRuleSets {
// push project through set operation
CoreRules.PROJECT_SET_OP_TRANSPOSE,
- // aggregation and projection rules
- CoreRules.AGGREGATE_PROJECT_PULL_UP_CONSTANTS,
- // push a projection past a filter or vice versa
- CoreRules.PROJECT_FILTER_TRANSPOSE, CoreRules.FILTER_PROJECT_TRANSPOSE,
- // push a projection to the children of a join
- // push all expressions to handle the time indicator correctly
+ // push a filter past a project
+ CoreRules.FILTER_PROJECT_TRANSPOSE,
+ // push parts of the join condition to its inputs
CoreRules.JOIN_CONDITION_PUSH,
// remove identity project
CoreRules.PROJECT_REMOVE,
@@ -64,14 +61,19 @@ public class PinotQueryRuleSets {
// push project through WINDOW
CoreRules.PROJECT_WINDOW_TRANSPOSE,
- // TODO: Revisit and see if they can be replaced with CoreRules.PROJECT_REDUCE_EXPRESSIONS and
- // CoreRules.FILTER_REDUCE_EXPRESSIONS
+ // literal rules
+ // TODO: Revisit and see if they can be replaced with
+ // CoreRules.PROJECT_REDUCE_EXPRESSIONS and
+ // CoreRules.FILTER_REDUCE_EXPRESSIONS
PinotEvaluateLiteralRule.Project.INSTANCE, PinotEvaluateLiteralRule.Filter.INSTANCE,
+ // sort join rules
// TODO: evaluate the SORT_JOIN_TRANSPOSE and SORT_JOIN_COPY rules
// join rules
CoreRules.JOIN_PUSH_EXPRESSIONS,
+
+ // join and semi-join rules
CoreRules.PROJECT_TO_SEMI_JOIN,
PinotAggregateToSemiJoinRule.INSTANCE,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org