You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/05 09:35:24 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #17448: Aws secrets manager backend

potiuk commented on a change in pull request #17448:
URL: https://github.com/apache/airflow/pull/17448#discussion_r702396133



##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -81,6 +105,7 @@ def __init__(
         profile_name: Optional[str] = None,
         sep: str = "/",
         full_url_mode: bool = True,
+        extra_conn_words: Optional[dict] = {},

Review comment:
       Oh. YEAH. That one is so non-obvious, but so dangerous. I think that was about the only really useful Pylint check that we miss now. But I just checked that we could use https://pypi.org/project/flake8-mutable/ extension.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org