[GitHub] [trafficserver] sudheerv commented on a change in pull request #7226: Bugfix: set a default inactivity timeout only if a read or write I/O operation was set

[GitBox <gi...@apache.org>]

sudheerv commented on a change in pull request #7226:
URL: https://github.com/apache/trafficserver/pull/7226#discussion_r497119122



##########
File path: iocore/net/UnixNet.cc
##########
@@ -70,7 +70,10 @@ class InactivityCop : public Continuation
       }
 
       // set a default inactivity timeout if one is not set
-      if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0) {
+      // The event `EVENT_INACTIVITY_TIMEOUT` only be triggered if a read
+      // or write I/O operation was set by `do_io_read()` or `do_io_write()`.
+      if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0 &&

Review comment:
       @bryancall Curious, do you configure active timeout for Server sessions? If there's no active timeout (which is how we configure for Server sessions), I'd think we should still set the default inactivity timeout just in case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org