[GitHub] [airflow] ferruzzi commented on a diff in pull request #28279: Add Amazon Elastic Container Registry (ECR) Hook

[GitBox <gi...@apache.org>]

ferruzzi commented on code in PR #28279:
URL: https://github.com/apache/airflow/pull/28279#discussion_r1047503127


##########
airflow/providers/amazon/aws/hooks/ecr.py:
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import base64
+import logging
+from dataclasses import dataclass
+from datetime import datetime
+
+from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook
+from airflow.utils.log.secrets_masker import mask_secret
+
+logger = logging.getLogger(__name__)
+
+
+@dataclass(frozen=True)
+class EcrCredentials:
+    """Helper (frozen dataclass) for storing temporary ECR credentials."""
+
+    username: str
+    password: str
+    proxy_endpoint: str
+    expires_at: datetime
+
+    def __post_init__(self):
+        mask_secret(self.password)
+        logger.debug("Credentials to Amazon ECR %r expires at %s.", self.proxy_endpoint, self.expires_at)
+
+    @property
+    def registry(self) -> str:
+        """Return registry in appropriate `docker login` format."""
+        # https://github.com/docker/docker-py/issues/2256#issuecomment-824940506
+        return self.proxy_endpoint.replace("https://", "")
+
+
+class EcrHook(AwsBaseHook):
+    """
+    Interact with Amazon Elastic Container Registry (ECR)
+
+    Additional arguments (such as ``aws_conn_id``) may be specified and
+    are passed down to the underlying AwsBaseHook.
+
+    .. seealso::
+        :class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook`
+    """
+
+    def __init__(self, **kwargs):
+        kwargs.pop("client_type", None)
+        super().__init__(client_type="ecr", **kwargs)

Review Comment:
   Small nitpick, but I'm always nagging about consistency.  Up to you.
   
   ```suggestion
           kwargs["client_type"] = "ecr"
           super().__init__(**kwargs)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org