You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (Updated) (JIRA)" <ji...@apache.org> on 2011/11/13 00:29:51 UTC
[jira] [Updated] (SOLR-2881) Trie fields should support
sortMissingLast="true"
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-2881:
---------------------------------
Attachment: SOLR-2881-3x.patch
I think this is ready to commit if we clear one thing up. Look at the tests and you'll see that default sorting for dates is a special case. The sorting behavior for dates is, indeed, different from longs when sortMissingFirst/Last are not specified. The behavior is consistent with 3.3 (it was handy to test 3.3 rather than 3.4) however, so neither LUCENE-3443 nor this patch change sorting in this case.
I'd like to commit this tomorrow (Sunday). Since the reconciliation process is a bit "interesting" between Mike's and my changes, I think that a patch for each is preferable, but we know I'm "merge challenged".
Note also that Mike, as part of 3441, made the parallel set of changes for 4.x already. That said, I'm going to create a small 4.x patch that changes the example schema.xml and incorporates the date test from this patch. I'll attach that file to SOLR-2134
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org