You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/14 08:00:45 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
AngersZhuuuu opened a new pull request #32163:
URL: https://github.com/apache/spark/pull/32163
### What changes were proposed in this pull request?
In current code, if we run spark sql with
```
./bin/spark-sql --verbose
```
It won't be passed to end SparkSQLCliDriver, then the SessionState won't call `setIsVerbose`
In the CLI option, it shows
```
CLI options:
-v,--verbose Verbose mode (echo executed SQL to the
console)
```
It's not consistent. This pr fix this issue
### Why are the changes needed?
Fix bug
### Does this PR introduce _any_ user-facing change?
when user call `-v` when run spark sql, sql will be echoed to console.
### How was this patch tested?
Added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819342734
**[Test build #137337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137337/testReport)** for PR 32163 at commit [`e7ccfa0`](https://github.com/apache/spark/commit/e7ccfa011888cb51976911d5cd60cf978b77d16d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-821923100
The JIRA number here was incorrect. It had to be SPARK-35068.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819443423
cc @wangyum too FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819450663
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137337/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819447586
**[Test build #137337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137337/testReport)** for PR 32163 at commit [`e7ccfa0`](https://github.com/apache/spark/commit/e7ccfa011888cb51976911d5cd60cf978b77d16d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819663807
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819662311
**[Test build #137350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137350/testReport)** for PR 32163 at commit [`195c933`](https://github.com/apache/spark/commit/195c933f1df8d1a54b3a6acfd3386a4b147beb11).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946331698
Looks like a bug, thanks @LuciferYang and @AngersZhuuuu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946335956
Found the reason, raise a fix pr soon and with a spark-shell verbose unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820014892
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41961/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819383855
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820089385
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137384/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820089385
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137384/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819957750
**[Test build #137384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137384/testReport)** for PR 32163 at commit [`4d88408`](https://github.com/apache/spark/commit/4d8840857288f4c71d02ac02a0f818249fb82caa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819539609
**[Test build #748540421](https://github.com/AngersZhuuuu/spark/actions/runs/748540421)** for PR 32163 at commit [`e7ccfa0`](https://github.com/AngersZhuuuu/spark/commit/e7ccfa011888cb51976911d5cd60cf978b77d16d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819569525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-821923361
I switched the JIRA between SPARK-35068 and SPARK-35086. cc @MaxGekk FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946328074
> We build a client with v3.2.0 and run `bin/spark-shell --master local --verbose`, the spark-shell startup failed now @AngersZhuuuu @cloud-fan @yaooqinn @dongjoon-hyun @HyukjinKwon @wangyum ,Is this expected?
>
> Also ping @toujours33
>
> ```
> Main class:
> org.apache.spark.repl.Main
> Arguments:
> --verbose
> Spark config:
> (spark.jars,)
> (spark.app.name,Spark shell)
> (spark.submit.pyFiles,)
> (spark.ui.showConsoleProgress,true)
> (spark.submit.deployMode,client)
> (spark.master,local)
> Classpath elements:
>
>
>
> Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
> Setting default log level to "WARN".
> To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
> bad option: '--verbose'
> ```
Checking this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820014282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820014892
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41961/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820096175
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819342734
**[Test build #137337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137337/testReport)** for PR 32163 at commit [`e7ccfa0`](https://github.com/apache/spark/commit/e7ccfa011888cb51976911d5cd60cf978b77d16d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946324057
We build a client with v3.2.0 and run `bin/spark-shell --master local --verbose`, the spark-shell startup failed now @AngersZhuuuu @cloud-fan @yaooqinn @dongjoon-hyun @HyukjinKwon @wangyum ,Is this expected?
Also ping @toujours33
```
Main class:
org.apache.spark.repl.Main
Arguments:
--verbose
Spark config:
(spark.jars,)
(spark.app.name,Spark shell)
(spark.submit.pyFiles,)
(spark.ui.showConsoleProgress,true)
(spark.submit.deployMode,client)
(spark.master,local)
Classpath elements:
Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
bad option: '--verbose'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946331500
Thanks @LuciferYang and @AngersZhuuuu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819357729
gentle ping @yaooqinn @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946329432
Thanks @AngersZhuuuu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32163:
URL: https://github.com/apache/spark/pull/32163#discussion_r613338282
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -594,4 +594,11 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
-> "BroadcastHashJoin"
)
}
+
+ test("SPARK-35086: --verbose should be passed to Spark SQL CLI") {
+ runCliWithin(2.minute,
Review comment:
nit: inline, `runCliWithin(2.minute, Seq("--verbose"))("SELECT 1;" -> "SELECT 1")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819663807
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819957750
**[Test build #137384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137384/testReport)** for PR 32163 at commit [`4d88408`](https://github.com/apache/spark/commit/4d8840857288f4c71d02ac02a0f818249fb82caa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819947683
**[Test build #750310558](https://github.com/AngersZhuuuu/spark/actions/runs/750310558)** for PR 32163 at commit [`4d88408`](https://github.com/AngersZhuuuu/spark/commit/4d8840857288f4c71d02ac02a0f818249fb82caa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819383826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819569579
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41929/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819569579
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41929/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819536016
**[Test build #137350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137350/testReport)** for PR 32163 at commit [`195c933`](https://github.com/apache/spark/commit/195c933f1df8d1a54b3a6acfd3386a4b147beb11).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #32163:
URL: https://github.com/apache/spark/pull/32163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819450663
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137337/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946324728
And `bin/spark-shell --master local --verbose` can startup spark-shell success use Spark 3.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819383855
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819536372
**[Test build #748540421](https://github.com/AngersZhuuuu/spark/actions/runs/748540421)** for PR 32163 at commit [`7ab7599`](https://github.com/AngersZhuuuu/spark/commit/7ab75993e281a79a614abc2fd964b5a3b3851e81).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-820084653
**[Test build #137384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137384/testReport)** for PR 32163 at commit [`4d88408`](https://github.com/apache/spark/commit/4d8840857288f4c71d02ac02a0f818249fb82caa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819536016
**[Test build #137350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137350/testReport)** for PR 32163 at commit [`195c933`](https://github.com/apache/spark/commit/195c933f1df8d1a54b3a6acfd3386a4b147beb11).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-819688975
**[Test build #748540421](https://github.com/AngersZhuuuu/spark/actions/runs/748540421)** for PR 32163 at commit [`195c933`](https://github.com/AngersZhuuuu/spark/commit/195c933f1df8d1a54b3a6acfd3386a4b147beb11).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #32163: [SPARK-35086][SQL][CORE] --verbose should be passed to Spark SQL CLI too
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #32163:
URL: https://github.com/apache/spark/pull/32163#issuecomment-946324728
And `bin/spark-shell --master local --verbose` can startup spark-shell succesfuls use Spark 3.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org