You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andera Del Bene (JIRA)" <ji...@apache.org> on 2010/09/26 15:46:33 UTC
[jira] Created: (WICKET-3080) Automatic sizing modal window
Automatic sizing modal window
-----------------------------
Key: WICKET-3080
URL: https://issues.apache.org/jira/browse/WICKET-3080
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Reporter: Andera Del Bene
Priority: Minor
As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3080) Automatic sizing modal window
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921245#action_12921245 ]
Hudson commented on WICKET-3080:
--------------------------------
Integrated in Apache Wicket 1.5.x #405 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/405/])
Issue: WICKET-3080
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-M3
>
> Attachments: FeatureQuickStart.zip, fix-WICKET-1.4.x.patch
>
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3080) Automatic sizing modal window
Posted by "Andera Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917760#action_12917760 ]
Andera Del Bene commented on WICKET-3080:
-----------------------------------------
Hi Igor,
should I add my patch to this issue or to a new one?
Thank you.
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3080) Automatic sizing modal window
Posted by "Andera Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andera Del Bene updated WICKET-3080:
------------------------------------
Attachment: FeatureQuickStart.zip
Eclipse project prototyping the new feature
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: FeatureQuickStart.zip, fix-WICKET-1.4.x.patch
>
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3080) Automatic sizing modal window
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917764#action_12917764 ]
Igor Vaynberg commented on WICKET-3080:
---------------------------------------
you can reopen and attach the patch to this one.
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3080) Automatic sizing modal window
Posted by "Andera Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andera Del Bene updated WICKET-3080:
------------------------------------
Attachment: fix-WICKET-1.4.x.patch
Patch file for new feature.
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: FeatureQuickStart.zip, fix-WICKET-1.4.x.patch
>
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3080) Automatic sizing modal window
Posted by "Andera Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andera Del Bene reopened WICKET-3080:
-------------------------------------
I've implemented automatic sizing coding a new JavaScript function in file modal.js. The function is autoSizeWindow() and is called in method show() only if we have set field autoSize to true. In order to do this I've added method setAutoSize() and field autoSize to class ModalWindow.
I think I've respected code conventions of both files.
The feature has been tested successfully under Firefox 3.6.10, Opera 10.6, Chrom 6 , IE 8 and IE 7. Unfortunately I didn't find the way to make it work under IE6 :-( . I hope it could be helpfull anyway.
Don't hesitate to contact me for any questions/doubts about this code.
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
> Attachments: FeatureQuickStart.zip, fix-WICKET-1.4.x.patch
>
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3080) Automatic sizing modal window
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3080.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-M3
>
> Attachments: FeatureQuickStart.zip, fix-WICKET-1.4.x.patch
>
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3080) Automatic sizing modal window
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3080.
-----------------------------------
Assignee: Igor Vaynberg
Resolution: Won't Fix
as far as i know this is not possible as the height of the content is usually controlled by the width. if you find a way to do this automatically and attach it as a patch we will be happy to include it.
cheers.
> Automatic sizing modal window
> -----------------------------
>
> Key: WICKET-3080
> URL: https://issues.apache.org/jira/browse/WICKET-3080
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Andera Del Bene
> Assignee: Igor Vaynberg
> Priority: Minor
>
> As default ModalWindow should automatically resizing itself in order to fit content's width and height. This should avoid manual size tuning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.