[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #788: Update documentation

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823216495



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##########
@@ -214,7 +214,7 @@ public Filter getFilter() {
             return filter;
         }
 
-        public B withtFilter(Filter filter) {
+        public B withFilter(Filter filter) {

Review comment:
       > I have mixed feelings about this change: yes, it would be nice to have a correctly spelled method, but the other one was already released and it is API.
   > 
   > Don't change the name of the method, deprecate it and add another one with the correct spelling.
   
   Just add a new method with the correct name and deprecate the bogus one. Simple ;-)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org