You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Kathey Marsden <km...@Sourcery.Org> on 2004/12/10 22:50:43 UTC
Re: [VOTE] [ [PATCH] Network Server XAMGR Level Support
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Army wrote:
> Is there a reason why we have the check for missingCodePoint AFTER the
> "switch", instead of before?
The attached patch has this change.
> might as well get it in print--have you run the derbynet and other
> related suites/tests with these changes, to make sure there aren't any
> regressions?
>
>
I ran derbyAll with the previous patch and derbynetmats with this
latest change that only affects network server.
Kathey Marsden wrote:
>> Attached is the updated patch for Network Server XAMGR Level 7 support.
>> I think I am ready to call a vote on whether it is OK to check this in.
>> As soon as I can check it in, I will be able to coordinate the changes
>> to the IBM Universal JDBC Driver. Even though you won't be able to test
>> the XA support until we have the client changes, I'd encourage voters
>> to test these changes with their existing network server applications to
>> ensure no regressions.
>>
>>
>>
Vote will now close end of day Tuesday, December 14.
Apologies for somehow accidentally sending the vote to derby-user
originally. Thanks to Dan for catching that.
See
http://nagoya.apache.org/eyebrowse/ReadMsg?listName=derby-user@db.apache.org&msgNo=311
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBuhozG0h36bFmkocRAhxjAJ4/Irxv+7GtADKTuw7tx4VJLyph0gCfXgQw
NtiL3WUX3AoXzXFj6nQCjGA=
=C4iX
-----END PGP SIGNATURE-----
Re: [VOTE] [ [PATCH] Network Server XAMGR Level Support
Posted by myrnap <my...@Golux.Com>.
myrnap wrote:
> Kathey Marsden wrote:
>
>> Daniel John Debrunner wrote:
>>
>>
>>> Kathey Marsden wrote:
>>>
>>> [XA changes for network server ]
>>>
>>> +1, with one minor question.
>>>
>>> Index: java/tools/org/apache/derby/impl/tools/ij/xaHelper.java
>>> - xaHelper.setDataSourceProperty(currentXADataSource,
>>> "dataSourceName", databaseName);
>>>
>>> Are you removing this line because JCC's XA data source doesn't support
>>> the dataSourceName property?
>>>
>>>
>>
>> Well, you know it does, so I really couldn't tell you why I took that
>> out. I'll put it back in and rerun tests.
>>
>> Thanks
>>
>> Kathey
>>
>>
> I wanted to do some tests with the patch sent to the list earlier, but
> I got a compilation error:
>
> It was looking for a DRDAXid class - which I didn't see in the patch...
>
> Thx.
> Myrna
>
That was about the previous iteration of the patch - mail got hold up
going out - the one sent on 12/15 does compile successfully.
Myrna
Re: [VOTE] [ [PATCH] Network Server XAMGR Level Support
Posted by myrnap <my...@golux.com>.
Kathey Marsden wrote:
>Daniel John Debrunner wrote:
>
>
>>Kathey Marsden wrote:
>>
>>[XA changes for network server ]
>>
>>+1, with one minor question.
>>
>>Index: java/tools/org/apache/derby/impl/tools/ij/xaHelper.java
>>- xaHelper.setDataSourceProperty(currentXADataSource,
>>"dataSourceName", databaseName);
>>
>>Are you removing this line because JCC's XA data source doesn't support
>>the dataSourceName property?
>>
>>
>>
>Well, you know it does, so I really couldn't tell you why I took that
>out. I'll put it back in and rerun tests.
>
>Thanks
>
>Kathey
>
>
I wanted to do some tests with the patch sent to the list earlier, but I
got a compilation error:
It was looking for a DRDAXid class - which I didn't see in the patch...
Thx.
Myrna
Re: [VOTE] [ [PATCH] Network Server XAMGR Leve 7 Support
Posted by Kathey Marsden <km...@Sourcery.Org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Well, it looks like my original patch was missing a new file
DRDAXid.java which is just the Xid implementation for Network Server.
Nothing too controversial in there I hope, but highly necessary.
The updated patch and the file are attached. I think it is ok to go
with lazy approval on this since the rest of the package already got 3
votes. If I don't hear any objections by the end of the day I will
check this in.
Thanks
Kathey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBwLRrG0h36bFmkocRAmXIAKDD4RruGMNOU1+WmbgdMwWFzW/rYQCgmK6B
AehZEwC2Mw5lOWjYvW8WtDQ=
=g0H8
-----END PGP SIGNATURE-----
Re: [VOTE] [ [PATCH] Network Server XAMGR Level Support
Posted by Kathey Marsden <km...@Sourcery.Org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Daniel John Debrunner wrote:
> Kathey Marsden wrote:
>
> [XA changes for network server ]
>
> +1, with one minor question.
>
> Index: java/tools/org/apache/derby/impl/tools/ij/xaHelper.java
> - xaHelper.setDataSourceProperty(currentXADataSource,
> "dataSourceName", databaseName);
>
> Are you removing this line because JCC's XA data source doesn't support
> the dataSourceName property?
>
Well, you know it does, so I really couldn't tell you why I took that
out. I'll put it back in and rerun tests.
Thanks
Kathey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBwDRJG0h36bFmkocRAo4eAJ42r78dAmNuRrZf46yhqMYKWJECtwCguInB
gm9Q6+IVyjHzV+eNAFBsoxE=
=uW4a
-----END PGP SIGNATURE-----
Re: [VOTE] [ [PATCH] Network Server XAMGR Level Support
Posted by Daniel John Debrunner <dj...@debrunners.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kathey Marsden wrote:
[XA changes for network server ]
+1, with one minor question.
Index: java/tools/org/apache/derby/impl/tools/ij/xaHelper.java
- - xaHelper.setDataSourceProperty(currentXADataSource,
"dataSourceName", databaseName);
Are you removing this line because JCC's XA data source doesn't support
the dataSourceName property?
Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFBv4+tIv0S4qsbfuQRAsRXAJ9vn/WRLa1t6557VM8KcVMcJRwSuACgwZxr
PM5oriZ5XQc0jPJM2+cXuYo=
=tIjA
-----END PGP SIGNATURE-----