You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/21 20:52:37 UTC
[GitHub] [pulsar] yaalsn opened a new pull request #14403: [Python Client] Fix ModuleNotFoundError is not defined in python2
yaalsn opened a new pull request #14403:
URL: https://github.com/apache/pulsar/pull/14403
Fixes #14193
### Motivation
`ModuleNotFoundError` is a builtin since python3.6. If we use python2 version pulsar, python will raise `NameError: name 'ModuleNotFoundError' is not defined` error.
### Modifications
Change `ModuleNotFoundError` to `ImportError`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yaalsn commented on pull request #14403: [Python Client] Fix ModuleNotFoundError is not defined in python2
Posted by GitBox <gi...@apache.org>.
yaalsn commented on pull request #14403:
URL: https://github.com/apache/pulsar/pull/14403#issuecomment-1047300913
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yaalsn commented on pull request #14403: [Python Client] Fix ModuleNotFoundError is not defined in python2
Posted by GitBox <gi...@apache.org>.
yaalsn commented on pull request #14403:
URL: https://github.com/apache/pulsar/pull/14403#issuecomment-1047226645
PTAL @merlimat @BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yaalsn commented on pull request #14403: [Python Client] Fix ModuleNotFoundError is not defined in python2
Posted by GitBox <gi...@apache.org>.
yaalsn commented on pull request #14403:
URL: https://github.com/apache/pulsar/pull/14403#issuecomment-1047335714
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yaalsn removed a comment on pull request #14403: [Python Client] Fix ModuleNotFoundError is not defined in python2
Posted by GitBox <gi...@apache.org>.
yaalsn removed a comment on pull request #14403:
URL: https://github.com/apache/pulsar/pull/14403#issuecomment-1047300913
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #14403: [Python Client] Fix ModuleNotFoundError is not defined in python2
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #14403:
URL: https://github.com/apache/pulsar/pull/14403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org