You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/04/04 16:41:25 UTC
[GitHub] [camel-k] gansheer opened a new pull request, #4230: fix(core): Fix copy local dependencies error message
gansheer opened a new pull request, #4230:
URL: https://github.com/apache/camel-k/pull/4230
Fixes #4198
## Motivation
An error message can be seen in the logs on operator startup sequence that gives the impression that the copy from runtime to local repository does not happen.
## Description
The actual copy is done but the library also tries to change the target directory to "0755" for the temp time of the copy but can't do it. The failure of the "chmod" only created an error log but does not prevent the copy.
The call is modified to avoid doing the permission modification as the Dockerfile already ensures that they are correct.
**Release Note**
```release-note
fix(core): Fix copy local dependencies error message
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4230: fix(core): Fix copy local dependencies error message
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4230:
URL: https://github.com/apache/camel-k/pull/4230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #4230: fix(core): Fix copy local dependencies error message
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4230:
URL: https://github.com/apache/camel-k/pull/4230#discussion_r1158114611
##########
e2e/install/cli/install_test.go:
##########
@@ -58,6 +58,7 @@ func TestBasicInstallation(t *testing.T) {
Eventually(IntegrationPodPhase(ns, "yaml"), TestTimeoutLong).Should(Equal(corev1.PodRunning))
Eventually(IntegrationConditionStatus(ns, "yaml", v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionTrue))
Eventually(IntegrationLogs(ns, "yaml"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+ Eventually(Exists(defaults.LocalRepository+"/org/apache/camel/k"), TestTimeoutShort).Should(Equal(true))
Review Comment:
+1 for adding a test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4230: fix(core): Fix copy local dependencies error message
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4230:
URL: https://github.com/apache/camel-k/pull/4230#issuecomment-1497047618
@gansheer
```
Error: e2e/support/test_support.go:2693:2: missing return
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on a diff in pull request #4230: fix(core): Fix copy local dependencies error message
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4230:
URL: https://github.com/apache/camel-k/pull/4230#discussion_r1158119953
##########
e2e/install/cli/install_test.go:
##########
@@ -58,6 +58,7 @@ func TestBasicInstallation(t *testing.T) {
Eventually(IntegrationPodPhase(ns, "yaml"), TestTimeoutLong).Should(Equal(corev1.PodRunning))
Eventually(IntegrationConditionStatus(ns, "yaml", v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionTrue))
Eventually(IntegrationLogs(ns, "yaml"), TestTimeoutShort).Should(ContainSubstring("Magicstring!"))
+ Eventually(Exists(defaults.LocalRepository+"/org/apache/camel/k"), TestTimeoutShort).Should(Equal(true))
Review Comment:
Let's hope it works...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org