[GitHub] [incubator-streampark] 1996fanrui commented on a diff in pull request #1938: [Feature] Support Flink 1.16 submit

[GitBox <gi...@apache.org>]

1996fanrui commented on code in PR #1938:
URL: https://github.com/apache/incubator-streampark/pull/1938#discussion_r1010381385


##########
streampark-flink/streampark-flink-proxy/src/main/scala/org/apache/streampark/flink/proxy/FlinkShimsProxy.scala:
##########
@@ -36,7 +36,7 @@ object FlinkShimsProxy extends Logger {
   )
 
   private[this] val SHIMS_PATTERN = Pattern.compile(
-    "streampark-flink-shims_flink-(1.12|1.13|1.14|1.15)_(2.11|2.12)-(.*).jar",
+    "streampark-flink-shims_flink-(1.12|1.13|1.14|1.15|1.16)_(2.11|2.12)-(.*).jar",

Review Comment:
   Hi @lvshaokang , thanks for your contribution. Most look good.
   
   Too many pattern, please extract a const field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org