You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/27 07:29:00 UTC
[GitHub] [spark] wangyum opened a new pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
wangyum opened a new pull request #31673:
URL: https://github.com/apache/spark/pull/31673
### What changes were proposed in this pull request?
Avro add zstandard codec since AVRO-2195. This pr add zstandard codec to Avro compression codec list.
### Why are the changes needed?
To make Avro support zstandard codec.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787036285
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40116/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787066256
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135535/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584083357
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -492,17 +493,21 @@ abstract class AvroSuite
df.write.format("avro").save(deflateDir)
spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "snappy")
df.write.format("avro").save(snappyDir)
+ spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "zstandard")
+ df.write.format("avro").save(zstandardDir)
Review comment:
@dongjoon-hyun To `zstandard` codec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584083511
##########
File path: pom.xml
##########
@@ -1235,6 +1235,10 @@
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ </exclusion>
Review comment:
Well, this is in my PR. Shall we merge mine and rebase your PR on the master branch?
- https://github.com/apache/spark/pull/31670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584085172
##########
File path: pom.xml
##########
@@ -1235,6 +1235,10 @@
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ </exclusion>
Review comment:
Yes. This is just to verify whether it can succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31673:
URL: https://github.com/apache/spark/pull/31673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787073653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40122/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584083552
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -492,17 +493,21 @@ abstract class AvroSuite
df.write.format("avro").save(deflateDir)
spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "snappy")
df.write.format("avro").save(snappyDir)
+ spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "zstandard")
+ df.write.format("avro").save(zstandardDir)
Review comment:
So, this is failing still?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787099892
**[Test build #135541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135541/testReport)** for PR 31673 at commit [`309de76`](https://github.com/apache/spark/commit/309de7623b30dcedeb0d1fee8984b97a7de275d9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787032947
**[Test build #135535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135535/testReport)** for PR 31673 at commit [`136c5b0`](https://github.com/apache/spark/commit/136c5b0dbb845119b09d43d3af555f07c08fdeca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787073653
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40122/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787040036
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40116/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584095037
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -492,17 +493,21 @@ abstract class AvroSuite
df.write.format("avro").save(deflateDir)
spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "snappy")
df.write.format("avro").save(snappyDir)
+ spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "zstandard")
+ df.write.format("avro").save(zstandardDir)
Review comment:
https://github.com/apache/spark/runs/1993307091?check_suite_focus=true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787032947
**[Test build #135535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135535/testReport)** for PR 31673 at commit [`136c5b0`](https://github.com/apache/spark/commit/136c5b0dbb845119b09d43d3af555f07c08fdeca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787066256
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135535/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787100137
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135541/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584083511
##########
File path: pom.xml
##########
@@ -1235,6 +1235,10 @@
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ </exclusion>
Review comment:
Well, this is in my PR. Shall we merge mine and replace this?
- https://github.com/apache/spark/pull/31670/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584083511
##########
File path: pom.xml
##########
@@ -1235,6 +1235,10 @@
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ </exclusion>
Review comment:
Well, this is in my PR. Shall we merge mine and rebase your PR on the master branch?
- https://github.com/apache/spark/pull/31670/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787044008
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40116/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584083357
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -492,17 +493,21 @@ abstract class AvroSuite
df.write.format("avro").save(deflateDir)
spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "snappy")
df.write.format("avro").save(snappyDir)
+ spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "zstandard")
+ df.write.format("avro").save(zstandardDir)
Review comment:
@dongjoon-hyun To test `zstandard` codec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787061289
**[Test build #135535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135535/testReport)** for PR 31673 at commit [`136c5b0`](https://github.com/apache/spark/commit/136c5b0dbb845119b09d43d3af555f07c08fdeca).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584087489
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -492,17 +493,21 @@ abstract class AvroSuite
df.write.format("avro").save(deflateDir)
spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "snappy")
df.write.format("avro").save(snappyDir)
+ spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "zstandard")
+ df.write.format("avro").save(zstandardDir)
Review comment:
Thank you for confirming and sharing this a nice test case. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787062689
**[Test build #135541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135541/testReport)** for PR 31673 at commit [`309de76`](https://github.com/apache/spark/commit/309de7623b30dcedeb0d1fee8984b97a7de275d9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31673:
URL: https://github.com/apache/spark/pull/31673#discussion_r584084925
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -492,17 +493,21 @@ abstract class AvroSuite
df.write.format("avro").save(deflateDir)
spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "snappy")
df.write.format("avro").save(snappyDir)
+ spark.conf.set(SQLConf.AVRO_COMPRESSION_CODEC.key, "zstandard")
+ df.write.format("avro").save(zstandardDir)
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787055333
Could you rebase this PR to the master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787100137
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135541/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787062689
**[Test build #135541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135541/testReport)** for PR 31673 at commit [`309de76`](https://github.com/apache/spark/commit/309de7623b30dcedeb0d1fee8984b97a7de275d9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787044530
I made a PR. It will unblock this issue.
- https://github.com/apache/spark/pull/31674
I verified the new ZSTD JNI library on top of this PR. `AvroV1Suite` and `AvroV2Suite` passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31673: [SPARK-34479][SQL] Add zstandard codec to Avro compression codec list
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31673:
URL: https://github.com/apache/spark/pull/31673#issuecomment-787044008
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40116/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org