You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ebyhr (via GitHub)" <gi...@apache.org> on 2026/05/01 05:46:16 UTC

[PR] Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties [iceberg]

ebyhr opened a new pull request, #16186:
URL: https://github.com/apache/iceberg/pull/16186

   com.azure:azure-security-keyvault-keys is currently a compile-only dependency.
   
   Without this change, any downstream application that uses AzureProperties will encounter a NoClassDefFound error.  
   Changing the return type is safe because Iceberg 1.10.x does not include [#13186](https://github.com/apache/iceberg/pull/13186)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #16186:
URL: https://github.com/apache/iceberg/pull/16186


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties [iceberg]

Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #16186:
URL: https://github.com/apache/iceberg/pull/16186#discussion_r3172591166


##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -135,9 +134,7 @@ public AzureProperties(Map<String, String> properties) {
     }
 
     this.keyWrapAlgorithm =
-        properties.getOrDefault(
-            AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM,
-            KeyWrapAlgorithm.RSA_OAEP_256.getValue());
+        properties.getOrDefault(AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM, "RSA-OAEP-256");

Review Comment:
   Thanks for the suggestion, updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #16186:
URL: https://github.com/apache/iceberg/pull/16186#discussion_r3172331133


##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -135,9 +134,7 @@ public AzureProperties(Map<String, String> properties) {
     }
 
     this.keyWrapAlgorithm =
-        properties.getOrDefault(
-            AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM,
-            KeyWrapAlgorithm.RSA_OAEP_256.getValue());
+        properties.getOrDefault(AzureProperties.AZURE_KEYVAULT_KEY_WRAP_ALGORITHM, "RSA-OAEP-256");

Review Comment:
   Could we extract this into a named constant with a comment noting which Azure SDK value it mirrors? Something like:
   ```
   > // Must match KeyWrapAlgorithm.RSA_OAEP_256.getValue() from azure-security-keyvault-keys
   > private static final String DEFAULT_KEY_WRAP_ALGORITHM = "RSA-OAEP-256";
   >
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Azure: Avoid depending on KeyWrapAlgorithm in AzureProperties [iceberg]

Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on PR #16186:
URL: https://github.com/apache/iceberg/pull/16186#issuecomment-4367569450

   @singhpk234 Trino Iceberg connecrtor doesn't use iceberg-azure module. It leads to a build failure with Maven duplicate-finder plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org