You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/16 00:56:00 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4211: StreamPartitionAssignmentStrategy interface to plug in various partition assignment strategies (uniform, replica group based)

codecov-io commented on issue #4211: StreamPartitionAssignmentStrategy interface to plug in various partition assignment strategies (uniform, replica group based)
URL: https://github.com/apache/incubator-pinot/pull/4211#issuecomment-492875911
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=h1) Report
   > Merging [#4211](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/40df151e79882a9debedc2971e71625659e4f24f?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `92.98%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4211/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4211      +/-   ##
   ============================================
   - Coverage     67.23%   67.21%   -0.03%     
   ============================================
     Files          1035     1038       +3     
     Lines         51515    51551      +36     
     Branches       7220     7227       +7     
   ============================================
   + Hits          34638    34650      +12     
   - Misses        14502    14532      +30     
   + Partials       2375     2369       -6
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../partition/StreamPartitionAssignmentGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcGFydGl0aW9uL1N0cmVhbVBhcnRpdGlvbkFzc2lnbm1lbnRHZW5lcmF0b3IuamF2YQ==) | `93.87% <100%> (-1.21%)` | `0 <0> (ø)` | |
   | [...tion/UniformStreamPartitionAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcGFydGl0aW9uL1VuaWZvcm1TdHJlYW1QYXJ0aXRpb25Bc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...ebalance/ReplicaGroupRebalanceSegmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYmFsYW5jZS9SZXBsaWNhR3JvdXBSZWJhbGFuY2VTZWdtZW50U3RyYXRlZ3kuamF2YQ==) | `82.25% <100%> (-0.16%)` | `0 <0> (ø)` | |
   | [...caGroupBasedStreamPartitionAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcGFydGl0aW9uL1JlcGxpY2FHcm91cEJhc2VkU3RyZWFtUGFydGl0aW9uQXNzaWdubWVudFN0cmF0ZWd5LmphdmE=) | `88.46% <88.46%> (ø)` | `0 <0> (?)` | |
   | [...tion/StreamPartitionAssignmentStrategyFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcGFydGl0aW9uL1N0cmVhbVBhcnRpdGlvbkFzc2lnbm1lbnRTdHJhdGVneUZhY3RvcnkuamF2YQ==) | `88.88% <88.88%> (ø)` | `0 <0> (?)` | |
   | [...apache/pinot/orc/data/readers/ORCRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3Qtb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9vcmMvZGF0YS9yZWFkZXJzL09SQ1JlY29yZFJlYWRlci5qYXZh) | `0% <0%> (-57.15%)` | `0% <0%> (-16%)` | |
   | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
   | [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `58.33% <0%> (-23.34%)` | `0% <0%> (ø)` | |
   | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `78.18% <0%> (-14.55%)` | `0% <0%> (ø)` | |
   | [...java/org/apache/pinot/filesystem/AzurePinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree#diff-cGlub3QtYXp1cmUtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9BenVyZVBpbm90RlMuamF2YQ==) | `0% <0%> (-11.96%)` | `0% <0%> (-4%)` | |
   | ... and [32 more](https://codecov.io/gh/apache/incubator-pinot/pull/4211/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=footer). Last update [40df151...83bb968](https://codecov.io/gh/apache/incubator-pinot/pull/4211?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org