You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2025/03/15 12:04:31 UTC
[I] Migrate datasource tests to `insta` [datafusion]
blaginin opened a new issue, #15246:
URL: https://github.com/apache/datafusion/issues/15246
In https://github.com/apache/datafusion/issues/15178, we're switching hard-coded constants in tests to `insta.`
This issue targets updating **datasource tests** (`datafusion/core/src/datasource`).
Examples of tests that need to be switched to `insta`
- https://github.com/apache/datafusion/blob/1eefd13ff76ac33d7053ef7b30d1a4677dcb73a7/datafusion/core/src/datasource/view.rs#L237-L243
- https://github.com/apache/datafusion/blob/1eefd13ff76ac33d7053ef7b30d1a4677dcb73a7/datafusion/core/src/datasource/file_format/csv.rs#L935-L938
- https://github.com/apache/datafusion/blob/1eefd13ff76ac33d7053ef7b30d1a4677dcb73a7/datafusion/core/src/datasource/view.rs#L548-L551
Check [the original issue](https://github.com/apache/datafusion/issues/15178) for tips on how to do the switch and examples of completed PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate datasource tests to `insta` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #15246: Migrate datasource tests to `insta`
URL: https://github.com/apache/datafusion/issues/15246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate datasource tests to `insta` [datafusion]
Posted by "shruti2522 (via GitHub)" <gi...@apache.org>.
shruti2522 commented on issue #15246:
URL: https://github.com/apache/datafusion/issues/15246#issuecomment-2726938676
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate datasource tests to `insta` [datafusion]
Posted by "sreshu (via GitHub)" <gi...@apache.org>.
sreshu commented on issue #15246:
URL: https://github.com/apache/datafusion/issues/15246#issuecomment-2734911692
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate datasource tests to `insta` [datafusion]
Posted by "l0kr (via GitHub)" <gi...@apache.org>.
l0kr commented on issue #15246:
URL: https://github.com/apache/datafusion/issues/15246#issuecomment-2759885021
@blaginin @alamb
Looks like PR was merged and issue should be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org