You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/02/27 06:12:35 UTC
[GitHub] zeppelin pull request #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic ...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2072
[ZEPPELIN-2060] Show tooltip msg after dynamic form value is changed
### What is this PR for?
As described in [ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060), the dynamic form's behaviour has been changed back and forth.
In current status(nothing happened when user change the dynamic form value), I made this tooltip msg automatically shows up. This will be helpful to let users know they need to click run button or `Shift+Enter`.
If there can be better way for this, please let me know :)
### What type of PR is it?
Improvement
### Todos
* [ ] - set timeout
### What is the Jira issue?
[ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060)
### How should this be tested?
1. Apply this patch and run Zeppelin web as dev mode
```bash
#under zeppelin-web
$yarn run dev
```
2. Go to Spark tutorial note and try to change value in dynamic forms as below screenshot imgs
### Screenshots (if appropriate)
After this change
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? yes?
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2060
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2072.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2072
----
commit 13218553aace1d08edeee086a23febf09654ee68
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-27T05:43:33Z
Show tooltip msg after dynamic form value is changed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2072
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic form va...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2072
@Leemoonsoo I checked now, the behaviour is same (the tooltip is shown right after sth changed in dynamic form) like default mode. I think this should be fixed. Maybe I need to hide this tooltip in report mode. Or maybe another tooltip msg can be shown sth like "You can't run the paragraph in report mode". Not sure which one is better.
BTW don't we need to block any changes in dynamic form then? Currently we can't run the paragraph since the run button is not shown and `Shift+Enter` doesn't work.
@Leemoonsoo @felixcheung Any suggestion will be appreciated :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic form va...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2072
@felixcheung Yeah that's possible way. Thanks!
Currently dynamic form itself is working in report mode by pressing `Enter` after the selected value changed. But the problem is it's not intuitive. Ppl don't know what they should do after changing value since it's automatically run before, but now it's not.
I created an another PR to improve the dynamic form behaviour in #2100. Can you take a look? I'm not sure which one is better. Maybe I can integrate two.. But it'll be better to get more feedbacks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic form va...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2072
dynamic form not working in report mode is a problem, right?
perhaps we get shift-enter to work and then anchor the tooltip to the textbox/dropdown etc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic form va...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2072
Great. How does it work in report mode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2072: [ZEPPELIN-2060] Show tooltip msg after dynamic form va...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2072
I'm closing this PR since https://issues.apache.org/jira/browse/ZEPPELIN-2060 will be handled in #2100.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---