You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/06/02 08:24:03 UTC
[PR] Refactor metadata database lookup to avoid duplicate contains/get access [shardingsphere]
menghaoranss opened a new pull request, #38774:
URL: https://github.com/apache/shardingsphere/pull/38774
Changes proposed in this pull request:
- Refactor metadata database lookup to avoid duplicate contains/get access
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor metadata database lookup to avoid duplicate contains/get access [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #38774:
URL: https://github.com/apache/shardingsphere/pull/38774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor metadata database lookup to avoid duplicate contains/get access [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #38774:
URL: https://github.com/apache/shardingsphere/pull/38774#issuecomment-4608105774
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** Latest PR head with added targeted regression coverage for the changed shared metadata lookup paths.
- **Not Reviewed Scope:** Local execution of some Mockito-inline-based tests may still depend on the reviewer’s JDK attach capability; no remaining code-level defect was identified in the PR itself.
- **Need Expert Review:** No
### Positive Feedback
- The optimization keeps the refactor focused on the metadata lookup hot path without expanding scope unnecessarily.
- The PR now adds direct regression coverage for the affected shared callers:
- `QueryContext#getUsedDatabases()` success and unknown-database failure
- `ProxySQLComQueryParser` empty database-name fallback path
- The previously identified test issue was limited to assertion style and has been corrected without changing production behavior.
### Residual Risk
- Remaining verification differences, if any, are expected to be environment-related (Mockito inline attach / JDK setup) rather than caused by the patch logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org