You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Scott Gray <sc...@hotwaxmedia.com> on 2011/09/12 00:50:28 UTC
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./ applications/party/servicedef/services.xml
Hi Jacques,
This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName and lastName being optional. It's also worth noting that they were made optional intentionally: http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
Regards
Scott
On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Sun Sep 4 22:07:12 2011
> New Revision: 1165122
>
> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
> Log:
> "Applied fix from trunk for revision: 1094007"
> ------------------------------------------------------------------------
> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>
> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field but this was not checked in the service definition.
> I extended the service definition, now first name and last name are not optional anymore.
>
> Orig Msg:
>
>
>> Hi list,
>>
>> In partymgr when I am creating a person then on the form first name and
>> last
>> name are required fields but If I submit the form without passing the first
>> name and last name , form gets submitted , it means required validations
>> are
>> not working. so I am curious to know Is there any problem with Validations
>> ?
>> I tried for the following url
>>
>>
>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>
> ------------------------------------------------------------------------
>
>
> Modified:
> ofbiz/branches/release10.04/ (props changed)
> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>
> Propchange: ofbiz/branches/release10.04/
> ------------------------------------------------------------------------------
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
> @@ -1,3 +1,3 @@
> /ofbiz/branches/addbirt:831210-885099,885686-886087
> /ofbiz/branches/multitenant20100310:921280-927264
> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>
> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
> ==============================================================================
> --- ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original)
> +++ ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011
> @@ -79,6 +79,8 @@ under the License.
> <attribute name="description" type="String" mode="IN" optional="true"/>
> <attribute name="externalId" type="String" mode="IN" optional="true"/>
> <attribute name="statusId" type="String" mode="IN" optional="true"/>
> + <override name="firstName" mode="IN" type="String" optional="false"/>
> + <override name="lastName" mode="IN" type="String" optional="false"/>
> </service>
> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin" auth="false">
>
>
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./ applications/party/servicedef/services.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
+1, I use it from time to time, especially if I want to receive email notifications about changes to a specific file which is a pretty awesome feature.
Regards
Scott
On 12/09/2011, at 12:24 PM, David E Jones wrote:
>
> My favorite is the FishEye UI, provided by Atlassian:
>
> https://fisheye6.atlassian.com/browse/ofbiz
>
> -David
>
>
> On Sep 11, 2011, at 5:19 PM, Scott Gray wrote:
>
>> As a side note, if anything seems in the least bit strange to me the first thing I ALWAYS do is to check the revision history for the code in question. It can give a lot of insight into why things are the way they are, who made it that way and provides the context for a discussion about making changes. It also avoids a situation like this where committers end up playing tag without ever noticing that it's even happening.
>>
>> Committers and devs, please bookmark and use these links:
>> http://svn.apache.org/viewvc/ofbiz/trunk/ - Apache SVN
>> http://svn.ofbiz.org/viewcvs/trunk/ - Pre-Apache SVN
>>
>> Regards
>> Scott
>>
>> On 12/09/2011, at 11:14 AM, Adrian Crum wrote:
>>
>>> Thanks for noticing that Scott. Actually, the change in the trunk is not a good one either - for the same reason.
>>>
>>> -Adrian
>>>
>>> On 9/11/2011 11:50 PM, Scott Gray wrote:
>>>> Hi Jacques,
>>>>
>>>> This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName and lastName being optional. It's also worth noting that they were made optional intentionally: http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
>>>>
>>>>> Author: jleroux
>>>>> Date: Sun Sep 4 22:07:12 2011
>>>>> New Revision: 1165122
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
>>>>> Log:
>>>>> "Applied fix from trunk for revision: 1094007"
>>>>> ------------------------------------------------------------------------
>>>>> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>>>>>
>>>>> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field but this was not checked in the service definition.
>>>>> I extended the service definition, now first name and last name are not optional anymore.
>>>>>
>>>>> Orig Msg:
>>>>>
>>>>>
>>>>>> Hi list,
>>>>>>
>>>>>> In partymgr when I am creating a person then on the form first name and
>>>>>> last
>>>>>> name are required fields but If I submit the form without passing the first
>>>>>> name and last name , form gets submitted , it means required validations
>>>>>> are
>>>>>> not working. so I am curious to know Is there any problem with Validations
>>>>>> ?
>>>>>> I tried for the following url
>>>>>>
>>>>>>
>>>>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>>>>> ------------------------------------------------------------------------
>>>>>
>>>>>
>>>>> Modified:
>>>>> ofbiz/branches/release10.04/ (props changed)
>>>>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>>>>
>>>>> Propchange: ofbiz/branches/release10.04/
>>>>> ------------------------------------------------------------------------------
>>>>> --- svn:mergeinfo (original)
>>>>> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
>>>>> @@ -1,3 +1,3 @@
>>>>> /ofbiz/branches/addbirt:831210-885099,885686-886087
>>>>> /ofbiz/branches/multitenant20100310:921280-927264
>>>>> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,99012
> 7,990
>>>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,10
> 7520
>>>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
>>>>> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,99012
> 7,990
>>>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,10
> 7520
>>>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>>>>>
>>>>> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
>>>>> ==============================================================================
>>>>> --- ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original)
>>>>> +++ ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011
>>>>> @@ -79,6 +79,8 @@ under the License.
>>>>> <attribute name="description" type="String" mode="IN" optional="true"/>
>>>>> <attribute name="externalId" type="String" mode="IN" optional="true"/>
>>>>> <attribute name="statusId" type="String" mode="IN" optional="true"/>
>>>>> +<override name="firstName" mode="IN" type="String" optional="false"/>
>>>>> +<override name="lastName" mode="IN" type="String" optional="false"/>
>>>>> </service>
>>>>> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
>>>>> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin" auth="false">
>>>>>
>>>>>
>>>
>>
>
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./
applications/party/servicedef/services.xml
Posted by David E Jones <de...@me.com>.
My favorite is the FishEye UI, provided by Atlassian:
https://fisheye6.atlassian.com/browse/ofbiz
-David
On Sep 11, 2011, at 5:19 PM, Scott Gray wrote:
> As a side note, if anything seems in the least bit strange to me the first thing I ALWAYS do is to check the revision history for the code in question. It can give a lot of insight into why things are the way they are, who made it that way and provides the context for a discussion about making changes. It also avoids a situation like this where committers end up playing tag without ever noticing that it's even happening.
>
> Committers and devs, please bookmark and use these links:
> http://svn.apache.org/viewvc/ofbiz/trunk/ - Apache SVN
> http://svn.ofbiz.org/viewcvs/trunk/ - Pre-Apache SVN
>
> Regards
> Scott
>
> On 12/09/2011, at 11:14 AM, Adrian Crum wrote:
>
>> Thanks for noticing that Scott. Actually, the change in the trunk is not a good one either - for the same reason.
>>
>> -Adrian
>>
>> On 9/11/2011 11:50 PM, Scott Gray wrote:
>>> Hi Jacques,
>>>
>>> This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName and lastName being optional. It's also worth noting that they were made optional intentionally: http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
>>>
>>> Regards
>>> Scott
>>>
>>> On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
>>>
>>>> Author: jleroux
>>>> Date: Sun Sep 4 22:07:12 2011
>>>> New Revision: 1165122
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
>>>> Log:
>>>> "Applied fix from trunk for revision: 1094007"
>>>> ------------------------------------------------------------------------
>>>> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>>>>
>>>> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field but this was not checked in the service definition.
>>>> I extended the service definition, now first name and last name are not optional anymore.
>>>>
>>>> Orig Msg:
>>>>
>>>>
>>>>> Hi list,
>>>>>
>>>>> In partymgr when I am creating a person then on the form first name and
>>>>> last
>>>>> name are required fields but If I submit the form without passing the first
>>>>> name and last name , form gets submitted , it means required validations
>>>>> are
>>>>> not working. so I am curious to know Is there any problem with Validations
>>>>> ?
>>>>> I tried for the following url
>>>>>
>>>>>
>>>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>>>> ------------------------------------------------------------------------
>>>>
>>>>
>>>> Modified:
>>>> ofbiz/branches/release10.04/ (props changed)
>>>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>>>
>>>> Propchange: ofbiz/branches/release10.04/
>>>> ------------------------------------------------------------------------------
>>>> --- svn:mergeinfo (original)
>>>> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
>>>> @@ -1,3 +1,3 @@
>>>> /ofbiz/branches/addbirt:831210-885099,885686-886087
>>>> /ofbiz/branches/multitenant20100310:921280-927264
>>>> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,99012
7,990
>>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,10
7520
>>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
>>>> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,99012
7,990
>>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,10
7520
>>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>>>>
>>>> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original)
>>>> +++ ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011
>>>> @@ -79,6 +79,8 @@ under the License.
>>>> <attribute name="description" type="String" mode="IN" optional="true"/>
>>>> <attribute name="externalId" type="String" mode="IN" optional="true"/>
>>>> <attribute name="statusId" type="String" mode="IN" optional="true"/>
>>>> +<override name="firstName" mode="IN" type="String" optional="false"/>
>>>> +<override name="lastName" mode="IN" type="String" optional="false"/>
>>>> </service>
>>>> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
>>>> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin" auth="false">
>>>>
>>>>
>>
>
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./ applications/party/servicedef/services.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
As a side note, if anything seems in the least bit strange to me the first thing I ALWAYS do is to check the revision history for the code in question. It can give a lot of insight into why things are the way they are, who made it that way and provides the context for a discussion about making changes. It also avoids a situation like this where committers end up playing tag without ever noticing that it's even happening.
Committers and devs, please bookmark and use these links:
http://svn.apache.org/viewvc/ofbiz/trunk/ - Apache SVN
http://svn.ofbiz.org/viewcvs/trunk/ - Pre-Apache SVN
Regards
Scott
On 12/09/2011, at 11:14 AM, Adrian Crum wrote:
> Thanks for noticing that Scott. Actually, the change in the trunk is not a good one either - for the same reason.
>
> -Adrian
>
> On 9/11/2011 11:50 PM, Scott Gray wrote:
>> Hi Jacques,
>>
>> This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName and lastName being optional. It's also worth noting that they were made optional intentionally: http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
>>
>> Regards
>> Scott
>>
>> On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
>>
>>> Author: jleroux
>>> Date: Sun Sep 4 22:07:12 2011
>>> New Revision: 1165122
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
>>> Log:
>>> "Applied fix from trunk for revision: 1094007"
>>> ------------------------------------------------------------------------
>>> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>>>
>>> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field but this was not checked in the service definition.
>>> I extended the service definition, now first name and last name are not optional anymore.
>>>
>>> Orig Msg:
>>>
>>>
>>>> Hi list,
>>>>
>>>> In partymgr when I am creating a person then on the form first name and
>>>> last
>>>> name are required fields but If I submit the form without passing the first
>>>> name and last name , form gets submitted , it means required validations
>>>> are
>>>> not working. so I am curious to know Is there any problem with Validations
>>>> ?
>>>> I tried for the following url
>>>>
>>>>
>>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>>> ------------------------------------------------------------------------
>>>
>>>
>>> Modified:
>>> ofbiz/branches/release10.04/ (props changed)
>>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>>
>>> Propchange: ofbiz/branches/release10.04/
>>> ------------------------------------------------------------------------------
>>> --- svn:mergeinfo (original)
>>> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
>>> @@ -1,3 +1,3 @@
>>> /ofbiz/branches/addbirt:831210-885099,885686-886087
>>> /ofbiz/branches/multitenant20100310:921280-927264
>>> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
>>> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>>>
>>> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
>>> ==============================================================================
>>> --- ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original)
>>> +++ ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011
>>> @@ -79,6 +79,8 @@ under the License.
>>> <attribute name="description" type="String" mode="IN" optional="true"/>
>>> <attribute name="externalId" type="String" mode="IN" optional="true"/>
>>> <attribute name="statusId" type="String" mode="IN" optional="true"/>
>>> +<override name="firstName" mode="IN" type="String" optional="false"/>
>>> +<override name="lastName" mode="IN" type="String" optional="false"/>
>>> </service>
>>> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
>>> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin" auth="false">
>>>
>>>
>
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./ applications/party/servicedef/services.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
Thanks for noticing that Scott. Actually, the change in the trunk is not
a good one either - for the same reason.
-Adrian
On 9/11/2011 11:50 PM, Scott Gray wrote:
> Hi Jacques,
>
> This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName and lastName being optional. It's also worth noting that they were made optional intentionally: http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
>
> Regards
> Scott
>
> On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Sun Sep 4 22:07:12 2011
>> New Revision: 1165122
>>
>> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
>> Log:
>> "Applied fix from trunk for revision: 1094007"
>> ------------------------------------------------------------------------
>> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>>
>> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field but this was not checked in the service definition.
>> I extended the service definition, now first name and last name are not optional anymore.
>>
>> Orig Msg:
>>
>>
>>> Hi list,
>>>
>>> In partymgr when I am creating a person then on the form first name and
>>> last
>>> name are required fields but If I submit the form without passing the first
>>> name and last name , form gets submitted , it means required validations
>>> are
>>> not working. so I am curious to know Is there any problem with Validations
>>> ?
>>> I tried for the following url
>>>
>>>
>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>> ------------------------------------------------------------------------
>>
>>
>> Modified:
>> ofbiz/branches/release10.04/ (props changed)
>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>
>> Propchange: ofbiz/branches/release10.04/
>> ------------------------------------------------------------------------------
>> --- svn:mergeinfo (original)
>> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
>> @@ -1,3 +1,3 @@
>> /ofbiz/branches/addbirt:831210-885099,885686-886087
>> /ofbiz/branches/multitenant20100310:921280-927264
>> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
>> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>>
>> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
>> ==============================================================================
>> --- ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original)
>> +++ ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011
>> @@ -79,6 +79,8 @@ under the License.
>> <attribute name="description" type="String" mode="IN" optional="true"/>
>> <attribute name="externalId" type="String" mode="IN" optional="true"/>
>> <attribute name="statusId" type="String" mode="IN" optional="true"/>
>> +<override name="firstName" mode="IN" type="String" optional="false"/>
>> +<override name="lastName" mode="IN" type="String" optional="false"/>
>> </service>
>> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
>> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin" auth="false">
>>
>>
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./ applications/party/servicedef/services.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
BTW, it would have been much easier for me if someone would have noticed it before. I wrote about it on user and dev MLs already some days ago (5 Sept.)
Thanks to care anyway
Jacques
Jacques Le Roux wrote:
> Thanks Scott,
>
> This was not pretty obvious. I will revert all (trunk included) and add a comment there for future, every where also... Is that
> not easier than any other means?
>
> BTW thanks for the info about FishEye feature to "receive email notifications about changes to a specific file"
>
> Jacques
>
> Scott Gray wrote:
>> Hi Jacques,
>>
>> This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName
>> and lastName being optional. It's also worth noting that they were made optional intentionally:
>> http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
>>
>> Regards
>> Scott
>>
>> On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
>>
>>> Author: jleroux
>>> Date: Sun Sep 4 22:07:12 2011
>>> New Revision: 1165122
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
>>> Log:
>>> "Applied fix from trunk for revision: 1094007"
>>> ------------------------------------------------------------------------
>>> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>>>
>>> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field
>>> but this was not checked in the service definition. I extended the service definition, now first name and last name are not
>>> optional anymore.
>>>
>>> Orig Msg:
>>>
>>>
>>>> Hi list,
>>>>
>>>> In partymgr when I am creating a person then on the form first name and
>>>> last
>>>> name are required fields but If I submit the form without passing the first
>>>> name and last name , form gets submitted , it means required validations
>>>> are
>>>> not working. so I am curious to know Is there any problem with Validations
>>>> ?
>>>> I tried for the following url
>>>>
>>>>
>>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> Modified:
>>> ofbiz/branches/release10.04/ (props changed)
>>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>>
>>> Propchange: ofbiz/branches/release10.04/
>>> ------------------------------------------------------------------------------
>>> --- svn:mergeinfo (original)
>>> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
>>> @@ -1,3 +1,3 @@
>>> /ofbiz/branches/addbirt:831210-885099,885686-886087
>>> /ofbiz/branches/multitenant20100310:921280-927264
>>> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
>>> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>>>
>>> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
>>> ============================================================================== ---
>>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original) +++
>>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011 @@ -79,6 +79,8 @@ under the
>>> License. <attribute name="description" type="String" mode="IN" optional="true"/>
>>> <attribute name="externalId" type="String" mode="IN" optional="true"/>
>>> <attribute name="statusId" type="String" mode="IN" optional="true"/>
>>> + <override name="firstName" mode="IN" type="String" optional="false"/>
>>> + <override name="lastName" mode="IN" type="String" optional="false"/>
>>> </service>
>>> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
>>> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin"
>>> auth="false">
Re: svn commit: r1165122 - in /ofbiz/branches/release10.04: ./ applications/party/servicedef/services.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Scott,
This was not pretty obvious. I will revert all (trunk included) and add a comment there for future, every where also... Is that not easier than any other means?
BTW thanks for the info about FishEye feature to "receive email notifications about changes to a specific file"
Jacques
Scott Gray wrote:
> Hi Jacques,
>
> This is not a good backport, changing the service definition could break deployments that have come to depend on the firstName
> and lastName being optional. It's also worth noting that they were made optional intentionally:
> http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=888986
>
> Regards
> Scott
>
> On 5/09/2011, at 10:07 AM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Sun Sep 4 22:07:12 2011
>> New Revision: 1165122
>>
>> URL: http://svn.apache.org/viewvc?rev=1165122&view=rev
>> Log:
>> "Applied fix from trunk for revision: 1094007"
>> ------------------------------------------------------------------------
>> r1094007 | sascharodekamp | 2011-04-16 17:15:27 +0200 (sam., 16 avr. 2011) | 20 lines
>>
>> Bug - Fixed a bug reported by Ravindra Mandre. When creating a party the first and last name were decalred as mandatory field
>> but this was not checked in the service definition. I extended the service definition, now first name and last name are not
>> optional anymore.
>>
>> Orig Msg:
>>
>>
>>> Hi list,
>>>
>>> In partymgr when I am creating a person then on the form first name and
>>> last
>>> name are required fields but If I submit the form without passing the first
>>> name and last name , form gets submitted , it means required validations
>>> are
>>> not working. so I am curious to know Is there any problem with Validations
>>> ?
>>> I tried for the following url
>>>
>>>
>>> https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?create_new=Y
>>
>> ------------------------------------------------------------------------
>>
>>
>> Modified:
>> ofbiz/branches/release10.04/ (props changed)
>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>>
>> Propchange: ofbiz/branches/release10.04/
>> ------------------------------------------------------------------------------
>> --- svn:mergeinfo (original)
>> +++ svn:mergeinfo Sun Sep 4 22:07:12 2011
>> @@ -1,3 +1,3 @@
>> /ofbiz/branches/addbirt:831210-885099,885686-886087
>> /ofbiz/branches/multitenant20100310:921280-927264
>> -/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036
>> +/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,940851,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,943843,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294,953671,954135,954583,954733,954956,955568,956022,956206,956340,957160,958343,958514,958521,958752,958758,958769,958953,959456,960143,960491,960997,963610,964558,965470,965916,966525,966785,967098,978806,978893,978939,979104,980641-980642,980935,981051,981104,981123,981288,983920,983930,985163,985298,985473,985718,985856,985902,987841,989166,990127,990
>> 339,990539,991485,993344,993387,995384,995686,996069,996078-996079,996563,997418-997420,997423-997425,997431,997440,997526,997990,998061,998412,998557,1000621,1000725,1000998,1001099,1001131,1001185,1001574,1001849,1001962,1002963,1003434,1003450,1003829,1004139,1027756,1027960,1028053,1028625,1028627,1029600,1030016,1030385,1030390,1033928,1033953,1034138,1034179,1035080,1035084,1036426,1036669,1037507,1037559-1037560,1037567,1037883,1038228,1038990,1039256,1040044,1040091,1042009,1042034,1042038,1042132,1042188,1042222,1042317,1042348,1042396,1042411,1042950,1043861,1043996-1043998,1044047,1044084,1044912,1049031,1050602,1051111,1051450,1051812,1052195,1053285,1053289,1053722,1054565,1055057,1056072,1056305,1056803,1057519,1058028,1058056,1058488,1059180,1060236,1060261,1060368,1060933,1061167,1061307,1061346,1061886,1061939,1062138,1062144,1062152,1063273,1064090,1064953,1064993,1065550,1066048,1067097,1067942,1069597,1069965,1070193,1070229,1072017,1072378,1074624,107520
>> 5,1075952,1076027,1076115,1080218,1080959,1083144,1084572,1084671,1084689,1084855,1085697,1085774,1090952,1090961,1090964,1092479,1094007,1094126,1096441,1098063,1104423,1131144,1132589,1132749,1134649,1134990,1135199,1135686,1137201,1137435,1139346,1139385,1139504,1140358,1140362,1140375,1140469,1144537,1144791,1153768,1158126,1159080,1163036,1163093
>>
>> Modified: ofbiz/branches/release10.04/applications/party/servicedef/services.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/party/servicedef/services.xml?rev=1165122&r1=1165121&r2=1165122&view=diff
>> ============================================================================== ---
>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml (original) +++
>> ofbiz/branches/release10.04/applications/party/servicedef/services.xml Sun Sep 4 22:07:12 2011 @@ -79,6 +79,8 @@ under the
>> License. <attribute name="description" type="String" mode="IN" optional="true"/>
>> <attribute name="externalId" type="String" mode="IN" optional="true"/>
>> <attribute name="statusId" type="String" mode="IN" optional="true"/>
>> + <override name="firstName" mode="IN" type="String" optional="false"/>
>> + <override name="lastName" mode="IN" type="String" optional="false"/>
>> </service>
>> <service name="createPersonAndUserLogin" engine="simple" require-new-transaction="true"
>> location="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml" invoke="createPersonAndUserLogin"
>> auth="false">