You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2013/01/15 19:30:06 UTC
svn commit: r1433569 [9/12] - in /httpcomponents:
benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/
benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/
benchmark/httpcore/trunk/src/main/java/org/apache/http/benchm...
Modified: httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/ResultProcessor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/ResultProcessor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/ResultProcessor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/ResultProcessor.java Tue Jan 15 18:29:58 2013
@@ -45,7 +45,7 @@ public class ResultProcessor {
nf6.setMinimumFractionDigits(6);
}
- static Results collectResults(BenchmarkWorker[] workers, HttpHost host, String uri) {
+ static Results collectResults(final BenchmarkWorker[] workers, final HttpHost host, final String uri) {
long totalTimeNano = 0;
long successCount = 0;
long failureCount = 0;
Modified: httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/Stats.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/Stats.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/Stats.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-ab/src/main/java/org/apache/http/benchmark/Stats.java Tue Jan 15 18:29:58 2013
@@ -112,7 +112,7 @@ public class Stats {
return this.totalBytesRecv;
}
- public void incTotalBytesRecv(long n) {
+ public void incTotalBytesRecv(final long n) {
this.totalBytesRecv += n;
}
@@ -120,7 +120,7 @@ public class Stats {
return this.totalBytesSent;
}
- public void incTotalBytesSent(long n) {
+ public void incTotalBytesSent(final long n) {
this.totalBytesSent += n;
}
@@ -128,7 +128,7 @@ public class Stats {
return this.contentLength;
}
- public void setContentLength(long contentLength) {
+ public void setContentLength(final long contentLength) {
this.contentLength = contentLength;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultClientIOEventDispatch.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultClientIOEventDispatch.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultClientIOEventDispatch.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultClientIOEventDispatch.java Tue Jan 15 18:29:58 2013
@@ -139,7 +139,7 @@ public class DefaultClientIOEventDispatc
}
@Override
- protected void onException(final NHttpClientIOTarget conn, IOException ex) {
+ protected void onException(final NHttpClientIOTarget conn, final IOException ex) {
this.handler.exception(conn, ex);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpClientIODispatch.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpClientIODispatch.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpClientIODispatch.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpClientIODispatch.java Tue Jan 15 18:29:58 2013
@@ -156,7 +156,7 @@ public class DefaultHttpClientIODispatch
}
@Override
- protected void onException(final DefaultNHttpClientConnection conn, IOException ex) {
+ protected void onException(final DefaultNHttpClientConnection conn, final IOException ex) {
this.handler.exception(conn, ex);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpServerIODispatch.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpServerIODispatch.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpServerIODispatch.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultHttpServerIODispatch.java Tue Jan 15 18:29:58 2013
@@ -148,7 +148,7 @@ public class DefaultHttpServerIODispatch
}
@Override
- protected void onException(final DefaultNHttpServerConnection conn, IOException ex) {
+ protected void onException(final DefaultNHttpServerConnection conn, final IOException ex) {
this.handler.exception(conn, ex);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpClientConnection.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpClientConnection.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpClientConnection.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpClientConnection.java Tue Jan 15 18:29:58 2013
@@ -127,7 +127,7 @@ public class DefaultNHttpClientConnectio
*/
public DefaultNHttpClientConnection(
final IOSession session,
- int buffersize,
+ final int buffersize,
final ByteBufferAllocator allocator,
final CharsetDecoder chardecoder,
final CharsetEncoder charencoder,
@@ -149,7 +149,7 @@ public class DefaultNHttpClientConnectio
*/
public DefaultNHttpClientConnection(
final IOSession session,
- int buffersize,
+ final int buffersize,
final CharsetDecoder chardecoder,
final CharsetEncoder charencoder,
final MessageConstraints constraints) {
@@ -160,7 +160,7 @@ public class DefaultNHttpClientConnectio
/**
* @since 4.3
*/
- public DefaultNHttpClientConnection(final IOSession session, int buffersize) {
+ public DefaultNHttpClientConnection(final IOSession session, final int buffersize) {
this(session, buffersize, null, null, null, null, null, null, null, null);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpServerConnection.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpServerConnection.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpServerConnection.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultNHttpServerConnection.java Tue Jan 15 18:29:58 2013
@@ -129,7 +129,7 @@ public class DefaultNHttpServerConnectio
*/
public DefaultNHttpServerConnection(
final IOSession session,
- int buffersize,
+ final int buffersize,
final ByteBufferAllocator allocator,
final CharsetDecoder chardecoder,
final CharsetEncoder charencoder,
@@ -152,7 +152,7 @@ public class DefaultNHttpServerConnectio
*/
public DefaultNHttpServerConnection(
final IOSession session,
- int buffersize,
+ final int buffersize,
final CharsetDecoder chardecoder,
final CharsetEncoder charencoder,
final MessageConstraints constraints) {
@@ -163,7 +163,7 @@ public class DefaultNHttpServerConnectio
/**
* @since 4.3
*/
- public DefaultNHttpServerConnection(final IOSession session, int buffersize) {
+ public DefaultNHttpServerConnection(final IOSession session, final int buffersize) {
this(session, buffersize, null, null, null, null, null, null, null, null);
}
@@ -364,7 +364,7 @@ public class DefaultNHttpServerConnectio
consumeInput(new NHttpServerEventHandlerAdaptor(handler));
}
- public void produceOutput(NHttpServiceHandler handler) {
+ public void produceOutput(final NHttpServiceHandler handler) {
produceOutput(new NHttpServerEventHandlerAdaptor(handler));
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultServerIOEventDispatch.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultServerIOEventDispatch.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultServerIOEventDispatch.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/DefaultServerIOEventDispatch.java Tue Jan 15 18:29:58 2013
@@ -137,7 +137,7 @@ public class DefaultServerIOEventDispatc
}
@Override
- protected void onException(final NHttpServerIOTarget conn, IOException ex) {
+ protected void onException(final NHttpServerIOTarget conn, final IOException ex) {
this.handler.exception(conn, ex);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/NHttpConnectionBase.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/NHttpConnectionBase.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/NHttpConnectionBase.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/NHttpConnectionBase.java Tue Jan 15 18:29:58 2013
@@ -200,7 +200,7 @@ public class NHttpConnectionBase
*/
protected NHttpConnectionBase(
final IOSession session,
- int buffersize,
+ final int buffersize,
final ByteBufferAllocator allocator,
final CharsetDecoder chardecoder,
final CharsetEncoder charencoder,
@@ -507,7 +507,7 @@ public class NHttpConnectionBase
}
}
- public void setSocketTimeout(int timeout) {
+ public void setSocketTimeout(final int timeout) {
this.session.setSocketTimeout(timeout);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityDecoder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityDecoder.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityDecoder.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityDecoder.java Tue Jan 15 18:29:58 2013
@@ -68,7 +68,7 @@ public class IdentityDecoder extends Abs
* some other means to know all the necessary data has been read and want to
* reuse the underlying connection for more messages.
*/
- public void setCompleted(boolean completed) {
+ public void setCompleted(final boolean completed) {
this.completed = completed;
}
@@ -95,8 +95,8 @@ public class IdentityDecoder extends Abs
public long transfer(
final FileChannel dst,
- long position,
- long count) throws IOException {
+ final long position,
+ final long count) throws IOException {
if (dst == null) {
return 0;
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityEncoder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityEncoder.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityEncoder.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/IdentityEncoder.java Tue Jan 15 18:29:58 2013
@@ -74,8 +74,8 @@ public class IdentityEncoder extends Abs
public long transfer(
final FileChannel src,
- long position,
- long count) throws IOException {
+ final long position,
+ final long count) throws IOException {
if (src == null) {
return 0;
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedDecoder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedDecoder.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedDecoder.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedDecoder.java Tue Jan 15 18:29:58 2013
@@ -64,7 +64,7 @@ public class LengthDelimitedDecoder exte
final ReadableByteChannel channel,
final SessionInputBuffer buffer,
final HttpTransportMetricsImpl metrics,
- long contentLength) {
+ final long contentLength) {
super(channel, buffer, metrics);
Args.notNegative(contentLength, "Content length");
this.contentLength = contentLength;
@@ -116,7 +116,7 @@ public class LengthDelimitedDecoder exte
public long transfer(
final FileChannel dst,
- long position,
+ final long position,
long count) throws IOException {
if (dst == null) {
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/codecs/LengthDelimitedEncoder.java Tue Jan 15 18:29:58 2013
@@ -63,7 +63,7 @@ public class LengthDelimitedEncoder exte
final WritableByteChannel channel,
final SessionOutputBuffer buffer,
final HttpTransportMetricsImpl metrics,
- long contentLength) {
+ final long contentLength) {
super(channel, buffer, metrics);
Args.notNegative(contentLength, "Content length");
this.contentLength = contentLength;
@@ -99,8 +99,8 @@ public class LengthDelimitedEncoder exte
public long transfer(
final FileChannel src,
- long position,
- long count) throws IOException {
+ final long position,
+ final long count) throws IOException {
if (src == null) {
return 0;
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractIOReactor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractIOReactor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractIOReactor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractIOReactor.java Tue Jan 15 18:29:58 2013
@@ -76,7 +76,7 @@ public abstract class AbstractIOReactor
* @param selectTimeout the select timeout.
* @throws IOReactorException in case if a non-recoverable I/O error.
*/
- public AbstractIOReactor(long selectTimeout) throws IOReactorException {
+ public AbstractIOReactor(final long selectTimeout) throws IOReactorException {
this(selectTimeout, false);
}
@@ -90,7 +90,7 @@ public abstract class AbstractIOReactor
*
* @since 4.1
*/
- public AbstractIOReactor(long selectTimeout, boolean interestOpsQueueing) throws IOReactorException {
+ public AbstractIOReactor(final long selectTimeout, final boolean interestOpsQueueing) throws IOReactorException {
super();
Args.positive(selectTimeout, "Select timeout");
this.selectTimeout = selectTimeout;
@@ -382,7 +382,7 @@ public abstract class AbstractIOReactor
SessionClosedCallback sessionClosedCallback = new SessionClosedCallback() {
- public void sessionClosed(IOSession session) {
+ public void sessionClosed(final IOSession session) {
queueClosedSession(session);
}
@@ -479,7 +479,7 @@ public abstract class AbstractIOReactor
* @param key the selection key.
* @param now current time as long value.
*/
- protected void timeoutCheck(final SelectionKey key, long now) {
+ protected void timeoutCheck(final SelectionKey key, final long now) {
IOSessionImpl session = (IOSessionImpl) key.attachment();
if (session != null) {
int timeout = session.getSocketTimeout();
@@ -579,7 +579,7 @@ public abstract class AbstractIOReactor
* @param timeout the maximum wait time.
* @throws InterruptedException if interrupted.
*/
- public void awaitShutdown(long timeout) throws InterruptedException {
+ public void awaitShutdown(final long timeout) throws InterruptedException {
synchronized (this.statusMutex) {
long deadline = System.currentTimeMillis() + timeout;
long remaining = timeout;
@@ -595,7 +595,7 @@ public abstract class AbstractIOReactor
}
}
- public void shutdown(long gracePeriod) throws IOReactorException {
+ public void shutdown(final long gracePeriod) throws IOReactorException {
if (this.status != IOReactorStatus.INACTIVE) {
gracefulShutdown();
try {
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractMultiworkerIOReactor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractMultiworkerIOReactor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractMultiworkerIOReactor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/AbstractMultiworkerIOReactor.java Tue Jan 15 18:29:58 2013
@@ -169,7 +169,7 @@ public abstract class AbstractMultiworke
this(null, null);
}
- static IOReactorConfig convert(int workerCount, final HttpParams params) {
+ static IOReactorConfig convert(final int workerCount, final HttpParams params) {
Args.notNull(params, "HTTP parameters");
IOReactorConfig config = IOReactorConfig.custom()
.setSelectInterval(NIOReactorParams.getSelectInterval(params))
@@ -200,7 +200,7 @@ public abstract class AbstractMultiworke
*/
@Deprecated
public AbstractMultiworkerIOReactor(
- int workerCount,
+ final int workerCount,
final ThreadFactory threadFactory,
final HttpParams params) throws IOReactorException {
this(convert(workerCount, params), threadFactory);
@@ -486,7 +486,7 @@ public abstract class AbstractMultiworke
* @throws ClosedChannelException if the channel has been already closed.
*/
protected SelectionKey registerChannel(
- final SelectableChannel channel, int ops) throws ClosedChannelException {
+ final SelectableChannel channel, final int ops) throws ClosedChannelException {
return channel.register(this.selector, ops);
}
@@ -515,7 +515,7 @@ public abstract class AbstractMultiworke
* @param timeout the maximum wait time.
* @throws InterruptedException if interrupted.
*/
- protected void awaitShutdown(long timeout) throws InterruptedException {
+ protected void awaitShutdown(final long timeout) throws InterruptedException {
synchronized (this.statusLock) {
long deadline = System.currentTimeMillis() + timeout;
long remaining = timeout;
@@ -535,7 +535,7 @@ public abstract class AbstractMultiworke
shutdown(2000);
}
- public void shutdown(long waitMs) throws IOException {
+ public void shutdown(final long waitMs) throws IOException {
synchronized (this.statusLock) {
if (this.status.compareTo(IOReactorStatus.ACTIVE) > 0) {
return;
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/BaseIOReactor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/BaseIOReactor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/BaseIOReactor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/BaseIOReactor.java Tue Jan 15 18:29:58 2013
@@ -68,7 +68,7 @@ public class BaseIOReactor extends Abstr
* @param selectTimeout the select timeout.
* @throws IOReactorException in case if a non-recoverable I/O error.
*/
- public BaseIOReactor(long selectTimeout) throws IOReactorException {
+ public BaseIOReactor(final long selectTimeout) throws IOReactorException {
this(selectTimeout, false);
}
@@ -83,7 +83,7 @@ public class BaseIOReactor extends Abstr
* @since 4.1
*/
public BaseIOReactor(
- long selectTimeout, boolean interestOpsQueueing) throws IOReactorException {
+ final long selectTimeout, final boolean interestOpsQueueing) throws IOReactorException {
super(selectTimeout, interestOpsQueueing);
this.bufferingSessions = new HashSet<IOSession>();
this.timeoutCheckInterval = selectTimeout;
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultConnectingIOReactor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultConnectingIOReactor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultConnectingIOReactor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultConnectingIOReactor.java Tue Jan 15 18:29:58 2013
@@ -112,7 +112,7 @@ public class DefaultConnectingIOReactor
*/
@Deprecated
public DefaultConnectingIOReactor(
- int workerCount,
+ final int workerCount,
final ThreadFactory threadFactory,
final HttpParams params) throws IOReactorException {
this(convert(workerCount, params), threadFactory);
@@ -123,7 +123,7 @@ public class DefaultConnectingIOReactor
*/
@Deprecated
public DefaultConnectingIOReactor(
- int workerCount,
+ final int workerCount,
final HttpParams params) throws IOReactorException {
this(convert(workerCount, params), null);
}
@@ -137,7 +137,7 @@ public class DefaultConnectingIOReactor
}
@Override
- protected void processEvents(int readyCount) throws IOReactorException {
+ protected void processEvents(final int readyCount) throws IOReactorException {
processSessionRequests();
if (readyCount > 0) {
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultListeningIOReactor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultListeningIOReactor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultListeningIOReactor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/DefaultListeningIOReactor.java Tue Jan 15 18:29:58 2013
@@ -115,7 +115,7 @@ public class DefaultListeningIOReactor e
*/
@Deprecated
public DefaultListeningIOReactor(
- int workerCount,
+ final int workerCount,
final ThreadFactory threadFactory,
final HttpParams params) throws IOReactorException {
this(convert(workerCount, params), threadFactory);
@@ -126,7 +126,7 @@ public class DefaultListeningIOReactor e
*/
@Deprecated
public DefaultListeningIOReactor(
- int workerCount,
+ final int workerCount,
final HttpParams params) throws IOReactorException {
this(convert(workerCount, params), null);
}
@@ -140,7 +140,7 @@ public class DefaultListeningIOReactor e
}
@Override
- protected void processEvents(int readyCount) throws IOReactorException {
+ protected void processEvents(final int readyCount) throws IOReactorException {
if (!this.paused) {
processSessionRequests();
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOReactorConfig.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOReactorConfig.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOReactorConfig.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOReactorConfig.java Tue Jan 15 18:29:58 2013
@@ -73,16 +73,16 @@ public final class IOReactorConfig imple
}
IOReactorConfig(
- long selectInterval,
- long shutdownGracePeriod,
- boolean interestOpQueued,
- int ioThreadCount,
- int soTimeout,
- boolean soReuseAddress,
- int soLinger,
- boolean soKeepAlive,
- boolean tcpNoDelay,
- int connectTimeout) {
+ final long selectInterval,
+ final long shutdownGracePeriod,
+ final boolean interestOpQueued,
+ final int ioThreadCount,
+ final int soTimeout,
+ final boolean soReuseAddress,
+ final int soLinger,
+ final boolean soKeepAlive,
+ final boolean tcpNoDelay,
+ final int connectTimeout) {
super();
this.selectInterval = selectInterval;
this.shutdownGracePeriod = shutdownGracePeriod;
@@ -107,7 +107,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setSelectInterval(long selectInterval) {
+ public void setSelectInterval(final long selectInterval) {
Args.positive(selectInterval, "Select internal");
this.selectInterval = selectInterval;
}
@@ -123,7 +123,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setShutdownGracePeriod(long gracePeriod) {
+ public void setShutdownGracePeriod(final long gracePeriod) {
Args.positive(gracePeriod, "Shutdown grace period");
this.shutdownGracePeriod = gracePeriod;
}
@@ -144,7 +144,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setInterestOpQueued(boolean interestOpQueued) {
+ public void setInterestOpQueued(final boolean interestOpQueued) {
this.interestOpQueued = interestOpQueued;
}
@@ -158,7 +158,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setIoThreadCount(int ioThreadCount) {
+ public void setIoThreadCount(final int ioThreadCount) {
Args.positive(ioThreadCount, "I/O thread count");
this.ioThreadCount = ioThreadCount;
}
@@ -175,7 +175,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setSoTimeout(int soTimeout) {
+ public void setSoTimeout(final int soTimeout) {
this.soTimeout = soTimeout;
}
@@ -192,7 +192,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setSoReuseAddress(boolean soReuseAddress) {
+ public void setSoReuseAddress(final boolean soReuseAddress) {
this.soReuseAddress = soReuseAddress;
}
@@ -209,7 +209,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setSoLinger(int soLinger) {
+ public void setSoLinger(final int soLinger) {
this.soLinger = soLinger;
}
@@ -226,7 +226,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setSoKeepalive(boolean soKeepAlive) {
+ public void setSoKeepalive(final boolean soKeepAlive) {
this.soKeepAlive = soKeepAlive;
}
@@ -243,7 +243,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setTcpNoDelay(boolean tcpNoDelay) {
+ public void setTcpNoDelay(final boolean tcpNoDelay) {
this.tcpNoDelay = tcpNoDelay;
}
@@ -257,7 +257,7 @@ public final class IOReactorConfig imple
}
@Deprecated
- public void setConnectTimeout(int connectTimeout) {
+ public void setConnectTimeout(final int connectTimeout) {
this.connectTimeout = connectTimeout;
}
@@ -311,52 +311,52 @@ public final class IOReactorConfig imple
this.connectTimeout = 0;
}
- public Builder setSelectInterval(long selectInterval) {
+ public Builder setSelectInterval(final long selectInterval) {
this.selectInterval = selectInterval;
return this;
}
- public Builder setShutdownGracePeriod(long shutdownGracePeriod) {
+ public Builder setShutdownGracePeriod(final long shutdownGracePeriod) {
this.shutdownGracePeriod = shutdownGracePeriod;
return this;
}
- public Builder setInterestOpQueued(boolean interestOpQueued) {
+ public Builder setInterestOpQueued(final boolean interestOpQueued) {
this.interestOpQueued = interestOpQueued;
return this;
}
- public Builder setIoThreadCount(int ioThreadCount) {
+ public Builder setIoThreadCount(final int ioThreadCount) {
this.ioThreadCount = ioThreadCount;
return this;
}
- public Builder setSoTimeout(int soTimeout) {
+ public Builder setSoTimeout(final int soTimeout) {
this.soTimeout = soTimeout;
return this;
}
- public Builder setSoReuseAddress(boolean soReuseAddress) {
+ public Builder setSoReuseAddress(final boolean soReuseAddress) {
this.soReuseAddress = soReuseAddress;
return this;
}
- public Builder setSoLinger(int soLinger) {
+ public Builder setSoLinger(final int soLinger) {
this.soLinger = soLinger;
return this;
}
- public Builder setSoKeepAlive(boolean soKeepAlive) {
+ public Builder setSoKeepAlive(final boolean soKeepAlive) {
this.soKeepAlive = soKeepAlive;
return this;
}
- public Builder setTcpNoDelay(boolean tcpNoDelay) {
+ public Builder setTcpNoDelay(final boolean tcpNoDelay) {
this.tcpNoDelay = tcpNoDelay;
return this;
}
- public Builder setConnectTimeout(int connectTimeout) {
+ public Builder setConnectTimeout(final int connectTimeout) {
this.connectTimeout = connectTimeout;
return this;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java Tue Jan 15 18:29:58 2013
@@ -138,7 +138,7 @@ public class IOSessionImpl implements IO
return this.interestOpsCallback != null ? this.currentEventMask : this.key.interestOps();
}
- public synchronized void setEventMask(int ops) {
+ public synchronized void setEventMask(final int ops) {
if (this.status == CLOSED) {
return;
}
@@ -157,7 +157,7 @@ public class IOSessionImpl implements IO
this.key.selector().wakeup();
}
- public synchronized void setEvent(int op) {
+ public synchronized void setEvent(final int op) {
if (this.status == CLOSED) {
return;
}
@@ -177,7 +177,7 @@ public class IOSessionImpl implements IO
this.key.selector().wakeup();
}
- public synchronized void clearEvent(int op) {
+ public synchronized void clearEvent(final int op) {
if (this.status == CLOSED) {
return;
}
@@ -201,7 +201,7 @@ public class IOSessionImpl implements IO
return this.socketTimeout;
}
- public synchronized void setSocketTimeout(int timeout) {
+ public synchronized void setSocketTimeout(final int timeout) {
this.socketTimeout = timeout;
this.lastAccessTime = System.currentTimeMillis();
}
@@ -294,7 +294,7 @@ public class IOSessionImpl implements IO
this.lastAccessTime = now;
}
- private static void formatOps(final StringBuilder buffer, int ops) {
+ private static void formatOps(final StringBuilder buffer, final int ops) {
if ((ops & SelectionKey.OP_READ) > 0) {
buffer.append('r');
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/InterestOpEntry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/InterestOpEntry.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/InterestOpEntry.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/InterestOpEntry.java Tue Jan 15 18:29:58 2013
@@ -42,7 +42,7 @@ class InterestOpEntry {
private final SelectionKey key;
private final int eventMask;
- public InterestOpEntry(final SelectionKey key, int eventMask) {
+ public InterestOpEntry(final SelectionKey key, final int eventMask) {
super();
Args.notNull(key, "Selection key");
this.key = key;
@@ -58,7 +58,7 @@ class InterestOpEntry {
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
return this.key.equals(obj);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionInputBufferImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionInputBufferImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionInputBufferImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionInputBufferImpl.java Tue Jan 15 18:29:58 2013
@@ -79,8 +79,8 @@ public class SessionInputBufferImpl exte
* @since 4.3
*/
public SessionInputBufferImpl(
- int buffersize,
- int lineBuffersize,
+ final int buffersize,
+ final int lineBuffersize,
final CharsetDecoder chardecoder,
final ByteBufferAllocator allocator) {
super(buffersize, allocator != null ? allocator : HeapByteBufferAllocator.INSTANCE);
@@ -95,8 +95,8 @@ public class SessionInputBufferImpl exte
*/
@Deprecated
public SessionInputBufferImpl(
- int buffersize,
- int lineBuffersize,
+ final int buffersize,
+ final int lineBuffersize,
final ByteBufferAllocator allocator,
final HttpParams params) {
super(buffersize, allocator);
@@ -122,8 +122,8 @@ public class SessionInputBufferImpl exte
*/
@Deprecated
public SessionInputBufferImpl(
- int buffersize,
- int linebuffersize,
+ final int buffersize,
+ final int linebuffersize,
final HttpParams params) {
this(buffersize, linebuffersize, HeapByteBufferAllocator.INSTANCE, params);
}
@@ -131,7 +131,7 @@ public class SessionInputBufferImpl exte
/**
* @since 4.3
*/
- public SessionInputBufferImpl(int buffersize) {
+ public SessionInputBufferImpl(final int buffersize) {
this(buffersize, 256, null, HeapByteBufferAllocator.INSTANCE);
}
@@ -139,8 +139,8 @@ public class SessionInputBufferImpl exte
* @since 4.3
*/
public SessionInputBufferImpl(
- int buffersize,
- int lineBuffersize,
+ final int buffersize,
+ final int lineBuffersize,
final Charset charset) {
this(buffersize, lineBuffersize,
charset != null ? charset.newDecoder() : null, HeapByteBufferAllocator.INSTANCE);
@@ -161,7 +161,7 @@ public class SessionInputBufferImpl exte
return this.buffer.get() & 0xff;
}
- public int read(final ByteBuffer dst, int maxLen) {
+ public int read(final ByteBuffer dst, final int maxLen) {
if (dst == null) {
return 0;
}
@@ -181,7 +181,7 @@ public class SessionInputBufferImpl exte
return read(dst, dst.remaining());
}
- public int read(final WritableByteChannel dst, int maxLen) throws IOException {
+ public int read(final WritableByteChannel dst, final int maxLen) throws IOException {
if (dst == null) {
return 0;
}
@@ -209,7 +209,7 @@ public class SessionInputBufferImpl exte
public boolean readLine(
final CharArrayBuffer linebuffer,
- boolean endOfStream) throws CharacterCodingException {
+ final boolean endOfStream) throws CharacterCodingException {
setOutputMode();
// See if there is LF char present in the buffer
@@ -311,7 +311,7 @@ public class SessionInputBufferImpl exte
return true;
}
- public String readLine(boolean endOfStream) throws CharacterCodingException {
+ public String readLine(final boolean endOfStream) throws CharacterCodingException {
CharArrayBuffer charbuffer = new CharArrayBuffer(64);
boolean found = readLine(charbuffer, endOfStream);
if (found) {
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionOutputBufferImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionOutputBufferImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionOutputBufferImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionOutputBufferImpl.java Tue Jan 15 18:29:58 2013
@@ -81,8 +81,8 @@ public class SessionOutputBufferImpl ext
* @since 4.3
*/
public SessionOutputBufferImpl(
- int buffersize,
- int lineBuffersize,
+ final int buffersize,
+ final int lineBuffersize,
final CharsetEncoder charencoder,
final ByteBufferAllocator allocator) {
super(buffersize, allocator != null ? allocator : HeapByteBufferAllocator.INSTANCE);
@@ -97,8 +97,8 @@ public class SessionOutputBufferImpl ext
*/
@Deprecated
public SessionOutputBufferImpl(
- int buffersize,
- int lineBuffersize,
+ final int buffersize,
+ final int lineBuffersize,
final ByteBufferAllocator allocator,
final HttpParams params) {
super(buffersize, allocator);
@@ -124,8 +124,8 @@ public class SessionOutputBufferImpl ext
*/
@Deprecated
public SessionOutputBufferImpl(
- int buffersize,
- int linebuffersize,
+ final int buffersize,
+ final int linebuffersize,
final HttpParams params) {
this(buffersize, linebuffersize, HeapByteBufferAllocator.INSTANCE, params);
}
@@ -133,7 +133,7 @@ public class SessionOutputBufferImpl ext
/**
* @since 4.3
*/
- public SessionOutputBufferImpl(int buffersize) {
+ public SessionOutputBufferImpl(final int buffersize) {
this(buffersize, 256, null, HeapByteBufferAllocator.INSTANCE);
}
@@ -141,8 +141,8 @@ public class SessionOutputBufferImpl ext
* @since 4.3
*/
public SessionOutputBufferImpl(
- int buffersize,
- int linebuffersize,
+ final int buffersize,
+ final int linebuffersize,
final Charset charset) {
this(buffersize, linebuffersize,
charset != null ? charset.newEncoder() : null, HeapByteBufferAllocator.INSTANCE);
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionRequestImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionRequestImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionRequestImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/SessionRequestImpl.java Tue Jan 15 18:29:58 2013
@@ -183,7 +183,7 @@ public class SessionRequestImpl implemen
return this.connectTimeout;
}
- public void setConnectTimeout(int timeout) {
+ public void setConnectTimeout(final int timeout) {
if (this.connectTimeout != timeout) {
this.connectTimeout = timeout;
SelectionKey key = this.key;
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentDecoderChannel.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentDecoderChannel.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentDecoderChannel.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentDecoderChannel.java Tue Jan 15 18:29:58 2013
@@ -42,11 +42,11 @@ public class ContentDecoderChannel imple
private final ContentDecoder decoder;
- public ContentDecoderChannel(ContentDecoder decoder) {
+ public ContentDecoderChannel(final ContentDecoder decoder) {
this.decoder = decoder;
}
- public int read(ByteBuffer dst) throws IOException {
+ public int read(final ByteBuffer dst) throws IOException {
return decoder.read(dst);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentEncoderChannel.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentEncoderChannel.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentEncoderChannel.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/ContentEncoderChannel.java Tue Jan 15 18:29:58 2013
@@ -42,11 +42,11 @@ public class ContentEncoderChannel imple
private final ContentEncoder contentEncoder;
- public ContentEncoderChannel(ContentEncoder contentEncoder) {
+ public ContentEncoderChannel(final ContentEncoder contentEncoder) {
this.contentEncoder = contentEncoder;
}
- public int write(ByteBuffer src) throws IOException {
+ public int write(final ByteBuffer src) throws IOException {
return contentEncoder.write(src);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ConsumingNHttpEntityTemplate.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ConsumingNHttpEntityTemplate.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ConsumingNHttpEntityTemplate.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ConsumingNHttpEntityTemplate.java Tue Jan 15 18:29:58 2013
@@ -74,7 +74,7 @@ public class ConsumingNHttpEntityTemplat
}
@Override
- public void writeTo(OutputStream out) throws IOException, UnsupportedOperationException {
+ public void writeTo(final OutputStream out) throws IOException, UnsupportedOperationException {
throw new UnsupportedOperationException("Does not support blocking methods");
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentInputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentInputStream.java Tue Jan 15 18:29:58 2013
@@ -61,7 +61,7 @@ public class ContentInputStream extends
}
@Override
- public int read(final byte[] b, int off, int len) throws IOException {
+ public int read(final byte[] b, final int off, final int len) throws IOException {
return this.buffer.read(b, off, len);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentOutputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentOutputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentOutputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentOutputStream.java Tue Jan 15 18:29:58 2013
@@ -60,12 +60,12 @@ public class ContentOutputStream extends
}
@Override
- public void write(byte[] b, int off, int len) throws IOException {
+ public void write(final byte[] b, final int off, final int len) throws IOException {
this.buffer.write(b, off, len);
}
@Override
- public void write(byte[] b) throws IOException {
+ public void write(final byte[] b) throws IOException {
if (b == null) {
return;
}
@@ -73,7 +73,7 @@ public class ContentOutputStream extends
}
@Override
- public void write(int b) throws IOException {
+ public void write(final int b) throws IOException {
this.buffer.write(b);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NByteArrayEntity.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NByteArrayEntity.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NByteArrayEntity.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NByteArrayEntity.java Tue Jan 15 18:29:58 2013
@@ -85,7 +85,7 @@ public class NByteArrayEntity extends Ab
/**
* @since 4.2
*/
- public NByteArrayEntity(final byte[] b, int off, int len, final ContentType contentType) {
+ public NByteArrayEntity(final byte[] b, final int off, final int len, final ContentType contentType) {
super();
Args.notNull(b, "Source byte array");
if ((off < 0) || (off > b.length) || (len < 0) ||
@@ -107,7 +107,7 @@ public class NByteArrayEntity extends Ab
this(b, null);
}
- public NByteArrayEntity(final byte[] b, int off, int len) {
+ public NByteArrayEntity(final byte[] b, final int off, final int len) {
this(b, off, len, null);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NFileEntity.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NFileEntity.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NFileEntity.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NFileEntity.java Tue Jan 15 18:29:58 2013
@@ -74,7 +74,7 @@ public class NFileEntity extends Abstrac
*
* @since 4.2
*/
- public NFileEntity(final File file, final ContentType contentType, boolean useFileChannels) {
+ public NFileEntity(final File file, final ContentType contentType, final boolean useFileChannels) {
Args.notNull(file, "File");
this.file = file;
this.useFileChannels = useFileChannels;
@@ -107,7 +107,7 @@ public class NFileEntity extends Abstrac
* @deprecated (4.2) use {@link #NFileEntity(File, ContentType, boolean)}
*/
@Deprecated
- public NFileEntity(final File file, final String contentType, boolean useFileChannels) {
+ public NFileEntity(final File file, final String contentType, final boolean useFileChannels) {
Args.notNull(file, "File");
this.file = file;
this.useFileChannels = useFileChannels;
@@ -153,7 +153,7 @@ public class NFileEntity extends Abstrac
return true;
}
- public void produceContent(ContentEncoder encoder, IOControl ioctrl)
+ public void produceContent(final ContentEncoder encoder, final IOControl ioctrl)
throws IOException {
if (fileChannel == null) {
FileInputStream in = new FileInputStream(file);
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NHttpEntityWrapper.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NHttpEntityWrapper.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NHttpEntityWrapper.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/NHttpEntityWrapper.java Tue Jan 15 18:29:58 2013
@@ -79,7 +79,7 @@ public class NHttpEntityWrapper
* This method throws {@link UnsupportedOperationException}.
*/
@Override
- public void writeTo(OutputStream out) throws IOException, UnsupportedOperationException {
+ public void writeTo(final OutputStream out) throws IOException, UnsupportedOperationException {
throw new UnsupportedOperationException("Does not support blocking methods");
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParamBean.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParamBean.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParamBean.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParamBean.java Tue Jan 15 18:29:58 2013
@@ -43,11 +43,11 @@ public class NIOReactorParamBean extends
super(params);
}
- public void setContentBufferSize (int contentBufferSize) {
+ public void setContentBufferSize (final int contentBufferSize) {
NIOReactorParams.setContentBufferSize(params, contentBufferSize);
}
- public void setSelectInterval (long selectInterval) {
+ public void setSelectInterval (final long selectInterval) {
NIOReactorParams.setSelectInterval(params, selectInterval);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/params/NIOReactorParams.java Tue Jan 15 18:29:58 2013
@@ -65,7 +65,7 @@ public final class NIOReactorParams impl
* @param params HTTP parameters.
* @param size content buffer size.
*/
- public static void setContentBufferSize(final HttpParams params, int size) {
+ public static void setContentBufferSize(final HttpParams params, final int size) {
Args.notNull(params, "HTTP parameters");
params.setIntParameter(CONTENT_BUFFER_SIZE, size);
}
@@ -88,7 +88,7 @@ public final class NIOReactorParams impl
* @param params HTTP parameters.
* @param ms I/O select interval in milliseconds.
*/
- public static void setSelectInterval(final HttpParams params, long ms) {
+ public static void setSelectInterval(final HttpParams params, final long ms) {
Args.notNull(params, "HTTP parameters");
params.setLongParameter(SELECT_INTERVAL, ms);
}
@@ -111,7 +111,7 @@ public final class NIOReactorParams impl
* @param params HTTP parameters.
* @param ms shutdown grace period in milliseconds.
*/
- public static void setGracePeriod(final HttpParams params, long ms) {
+ public static void setGracePeriod(final HttpParams params, final long ms) {
Args.notNull(params, "HTTP parameters");
params.setLongParameter(GRACE_PERIOD, ms);
}
@@ -139,7 +139,7 @@ public final class NIOReactorParams impl
* @since 4.1
*/
public static void setInterestOpsQueueing(
- final HttpParams params, boolean interestOpsQueueing) {
+ final HttpParams params, final boolean interestOpsQueueing) {
Args.notNull(params, "HTTP parameters");
params.setBooleanParameter(INTEREST_OPS_QUEUEING, interestOpsQueueing);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/AbstractNIOConnPool.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/AbstractNIOConnPool.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/AbstractNIOConnPool.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/AbstractNIOConnPool.java Tue Jan 15 18:29:58 2013
@@ -86,8 +86,8 @@ public abstract class AbstractNIOConnPoo
public AbstractNIOConnPool(
final ConnectingIOReactor ioreactor,
final NIOConnFactory<T, C> connFactory,
- int defaultMaxPerRoute,
- int maxTotal) {
+ final int defaultMaxPerRoute,
+ final int maxTotal) {
super();
Args.notNull(ioreactor, "I/O reactor");
Args.notNull(connFactory, "Connection factory");
@@ -117,7 +117,7 @@ public abstract class AbstractNIOConnPoo
return this.isShutDown;
}
- public void shutdown(long waitMs) throws IOException {
+ public void shutdown(final long waitMs) throws IOException {
if (this.isShutDown) {
return ;
}
@@ -192,7 +192,7 @@ public abstract class AbstractNIOConnPoo
return lease(route, state, -1, TimeUnit.MICROSECONDS, null);
}
- public void release(final E entry, boolean reusable) {
+ public void release(final E entry, final boolean reusable) {
if (entry == null) {
return;
}
@@ -406,7 +406,7 @@ public abstract class AbstractNIOConnPoo
}
}
- public void setMaxTotal(int max) {
+ public void setMaxTotal(final int max) {
Args.positive(max, "Max value");
this.lock.lock();
try {
@@ -425,7 +425,7 @@ public abstract class AbstractNIOConnPoo
}
}
- public void setDefaultMaxPerRoute(int max) {
+ public void setDefaultMaxPerRoute(final int max) {
Args.positive(max, "Max value");
this.lock.lock();
try {
@@ -444,7 +444,7 @@ public abstract class AbstractNIOConnPoo
}
}
- public void setMaxPerRoute(final T route, int max) {
+ public void setMaxPerRoute(final T route, final int max) {
Args.notNull(route, "Route");
Args.positive(max, "Max value");
this.lock.lock();
@@ -455,7 +455,7 @@ public abstract class AbstractNIOConnPoo
}
}
- public int getMaxPerRoute(T route) {
+ public int getMaxPerRoute(final T route) {
Args.notNull(route, "Route");
this.lock.lock();
try {
@@ -493,7 +493,7 @@ public abstract class AbstractNIOConnPoo
}
}
- public void closeIdle(long idletime, final TimeUnit tunit) {
+ public void closeIdle(final long idletime, final TimeUnit tunit) {
Args.notNull(tunit, "Time unit");
long time = tunit.toMillis(idletime);
if (time < 0) {
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/RouteSpecificPool.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/RouteSpecificPool.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/RouteSpecificPool.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/pool/RouteSpecificPool.java Tue Jan 15 18:29:58 2013
@@ -119,7 +119,7 @@ abstract class RouteSpecificPool<T, C, E
return true;
}
- public void free(final E entry, boolean reusable) {
+ public void free(final E entry, final boolean reusable) {
Args.notNull(entry, "Pool entry");
boolean found = this.leased.remove(entry);
Asserts.check(found, "Entry %s has not been leased from this pool", entry);
@@ -146,7 +146,7 @@ abstract class RouteSpecificPool<T, C, E
return entry;
}
- public void completed(SessionRequest request, E entry) {
+ public void completed(final SessionRequest request, final E entry) {
BasicFuture<E> future = removeRequest(request);
future.completed(entry);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpClientHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpClientHandler.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpClientHandler.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpClientHandler.java Tue Jan 15 18:29:58 2013
@@ -468,7 +468,7 @@ public class AsyncNHttpClientHandler ext
return this.outputState;
}
- public void setOutputState(int outputState) {
+ public void setOutputState(final int outputState) {
this.outputState = outputState;
}
@@ -492,7 +492,7 @@ public class AsyncNHttpClientHandler ext
return this.timeout;
}
- public void setTimeout(int timeout) {
+ public void setTimeout(final int timeout) {
this.timeout = timeout;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpServiceHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpServiceHandler.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpServiceHandler.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/AsyncNHttpServiceHandler.java Tue Jan 15 18:29:58 2013
@@ -513,10 +513,10 @@ public class AsyncNHttpServiceHandler ex
* response. If there is an entity, it will be called after the entity has
* completed.
*/
- protected void responseComplete(HttpResponse response, HttpContext context) {
+ protected void responseComplete(final HttpResponse response, final HttpContext context) {
}
- private NHttpRequestHandler getRequestHandler(HttpRequest request) {
+ private NHttpRequestHandler getRequestHandler(final HttpRequest request) {
NHttpRequestHandler handler = null;
if (this.handlerResolver != null) {
String requestURI = request.getRequestLine().getUri();
@@ -638,7 +638,7 @@ public class AsyncNHttpServiceHandler ex
return this.handled;
}
- public void setHandled(boolean handled) {
+ public void setHandled(final boolean handled) {
this.handled = handled;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/BufferingHttpServiceHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/BufferingHttpServiceHandler.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/BufferingHttpServiceHandler.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/BufferingHttpServiceHandler.java Tue Jan 15 18:29:58 2013
@@ -151,7 +151,7 @@ public class BufferingHttpServiceHandler
this.asyncHandler.exception(conn, ioex);
}
- public void timeout(NHttpServerConnection conn) {
+ public void timeout(final NHttpServerConnection conn) {
this.asyncHandler.timeout(conn);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java Tue Jan 15 18:29:58 2013
@@ -89,7 +89,7 @@ public class HttpAsyncRequestExecutor im
*
* @since 4.3
*/
- public HttpAsyncRequestExecutor(int waitForContinue) {
+ public HttpAsyncRequestExecutor(final int waitForContinue) {
super();
this.waitForContinue = Args.positive(waitForContinue, "Wait for continue time");
}
@@ -438,7 +438,7 @@ public class HttpAsyncRequestExecutor im
return this.timeout;
}
- public void setTimeout(int timeout) {
+ public void setTimeout(final int timeout) {
this.timeout = timeout;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestHandlerRegistry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestHandlerRegistry.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestHandlerRegistry.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestHandlerRegistry.java Tue Jan 15 18:29:58 2013
@@ -95,7 +95,7 @@ public class HttpAsyncRequestHandlerRegi
return matcher.getObjects();
}
- public HttpAsyncRequestHandler<?> lookup(String requestURI) {
+ public HttpAsyncRequestHandler<?> lookup(final String requestURI) {
return matcher.lookup(requestURI);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequester.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequester.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequester.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequester.java Tue Jan 15 18:29:58 2013
@@ -408,7 +408,7 @@ public class HttpAsyncRequester {
*
* @param ex I/O exception thrown by {@link Closeable#close()}
*/
- protected void log(Exception ex) {
+ protected void log(final Exception ex) {
}
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncService.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncService.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncService.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncService.java Tue Jan 15 18:29:58 2013
@@ -798,7 +798,7 @@ public class HttpAsyncService implements
return this.completed;
}
- public void setTimeout(int timeout) {
+ public void setTimeout(final int timeout) {
this.conn.setSocketTimeout(timeout);
}
@@ -820,7 +820,7 @@ public class HttpAsyncService implements
this.resolver = resolver;
}
- public HttpAsyncRequestHandler<?> lookup(HttpRequest request) {
+ public HttpAsyncRequestHandler<?> lookup(final HttpRequest request) {
return resolver.lookup(request.getRequestLine().getUri());
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NHttpRequestHandlerRegistry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NHttpRequestHandlerRegistry.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NHttpRequestHandlerRegistry.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NHttpRequestHandlerRegistry.java Tue Jan 15 18:29:58 2013
@@ -97,7 +97,7 @@ public class NHttpRequestHandlerRegistry
return matcher.getObjects();
}
- public NHttpRequestHandler lookup(String requestURI) {
+ public NHttpRequestHandler lookup(final String requestURI) {
return matcher.lookup(requestURI);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NullNHttpEntity.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NullNHttpEntity.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NullNHttpEntity.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/NullNHttpEntity.java Tue Jan 15 18:29:58 2013
@@ -62,7 +62,7 @@ class NullNHttpEntity extends HttpEntity
}
@Override
- public void writeTo(OutputStream out) throws IOException, UnsupportedOperationException {
+ public void writeTo(final OutputStream out) throws IOException, UnsupportedOperationException {
throw new UnsupportedOperationException("Does not support blocking methods");
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpClientHandler.java Tue Jan 15 18:29:58 2013
@@ -583,7 +583,7 @@ public class ThrottlingHttpClientHandler
private volatile boolean workerRunning;
public ClientConnState(
- int bufsize,
+ final int bufsize,
final IOControl ioControl,
final ByteBufferAllocator allocator) {
super();
@@ -605,7 +605,7 @@ public class ThrottlingHttpClientHandler
return this.inputState;
}
- public void setInputState(int inputState) {
+ public void setInputState(final int inputState) {
this.inputState = inputState;
}
@@ -613,7 +613,7 @@ public class ThrottlingHttpClientHandler
return this.outputState;
}
- public void setOutputState(int outputState) {
+ public void setOutputState(final int outputState) {
this.outputState = outputState;
}
@@ -637,7 +637,7 @@ public class ThrottlingHttpClientHandler
return this.timeout;
}
- public void setTimeout(int timeout) {
+ public void setTimeout(final int timeout) {
this.timeout = timeout;
}
@@ -645,7 +645,7 @@ public class ThrottlingHttpClientHandler
return this.workerRunning;
}
- public void setWorkerRunning(boolean b) {
+ public void setWorkerRunning(final boolean b) {
this.workerRunning = b;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpServiceHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpServiceHandler.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpServiceHandler.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/protocol/ThrottlingHttpServiceHandler.java Tue Jan 15 18:29:58 2013
@@ -643,7 +643,7 @@ public class ThrottlingHttpServiceHandle
private volatile boolean expectationFailure;
public ServerConnState(
- int bufsize,
+ final int bufsize,
final IOControl ioControl,
final ByteBufferAllocator allocator) {
super();
@@ -665,7 +665,7 @@ public class ThrottlingHttpServiceHandle
return this.inputState;
}
- public void setInputState(int inputState) {
+ public void setInputState(final int inputState) {
this.inputState = inputState;
}
@@ -673,7 +673,7 @@ public class ThrottlingHttpServiceHandle
return this.outputState;
}
- public void setOutputState(int outputState) {
+ public void setOutputState(final int outputState) {
this.outputState = outputState;
}
@@ -697,7 +697,7 @@ public class ThrottlingHttpServiceHandle
return expectationFailure;
}
- public void setExpectationFailed(boolean b) {
+ public void setExpectationFailed(final boolean b) {
this.expectationFailure = b;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/reactor/ssl/SSLIOSession.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/reactor/ssl/SSLIOSession.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/reactor/ssl/SSLIOSession.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/reactor/ssl/SSLIOSession.java Tue Jan 15 18:29:58 2013
@@ -505,17 +505,17 @@ public class SSLIOSession implements IOS
return this.appEventMask;
}
- public synchronized void setEventMask(int ops) {
+ public synchronized void setEventMask(final int ops) {
this.appEventMask = ops;
updateEventMask();
}
- public synchronized void setEvent(int op) {
+ public synchronized void setEvent(final int op) {
this.appEventMask = this.appEventMask | op;
updateEventMask();
}
- public synchronized void clearEvent(int op) {
+ public synchronized void clearEvent(final int op) {
this.appEventMask = this.appEventMask & ~op;
updateEventMask();
}
@@ -524,7 +524,7 @@ public class SSLIOSession implements IOS
return this.session.getSocketTimeout();
}
- public void setSocketTimeout(int timeout) {
+ public void setSocketTimeout(final int timeout) {
this.session.setSocketTimeout(timeout);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/DirectByteBufferAllocator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/DirectByteBufferAllocator.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/DirectByteBufferAllocator.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/DirectByteBufferAllocator.java Tue Jan 15 18:29:58 2013
@@ -46,7 +46,7 @@ public class DirectByteBufferAllocator i
super();
}
- public ByteBuffer allocate(int size) {
+ public ByteBuffer allocate(final int size) {
return ByteBuffer.allocateDirect(size);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/ExpandableBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/ExpandableBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/ExpandableBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/ExpandableBuffer.java Tue Jan 15 18:29:58 2013
@@ -60,7 +60,7 @@ public class ExpandableBuffer implements
* @param buffersize the buffer size.
* @param allocator allocator to be used to allocate {@link ByteBuffer}s.
*/
- public ExpandableBuffer(int buffersize, final ByteBufferAllocator allocator) {
+ public ExpandableBuffer(final int buffersize, final ByteBufferAllocator allocator) {
super();
Args.notNull(allocator, "ByteBuffer allocator");
this.allocator = allocator;
@@ -105,7 +105,7 @@ public class ExpandableBuffer implements
}
}
- private void expandCapacity(int capacity) {
+ private void expandCapacity(final int capacity) {
ByteBuffer oldbuffer = this.buffer;
this.buffer = allocator.allocate(capacity);
oldbuffer.flip();
@@ -128,7 +128,7 @@ public class ExpandableBuffer implements
*
* @param requiredCapacity
*/
- protected void ensureCapacity(int requiredCapacity) {
+ protected void ensureCapacity(final int requiredCapacity) {
if (requiredCapacity > this.buffer.capacity()) {
expandCapacity(requiredCapacity);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/HeapByteBufferAllocator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/HeapByteBufferAllocator.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/HeapByteBufferAllocator.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/HeapByteBufferAllocator.java Tue Jan 15 18:29:58 2013
@@ -46,7 +46,7 @@ public class HeapByteBufferAllocator imp
super();
}
- public ByteBuffer allocate(int size) {
+ public ByteBuffer allocate(final int size) {
return ByteBuffer.allocate(size);
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java Tue Jan 15 18:29:58 2013
@@ -65,7 +65,7 @@ public class SharedInputBuffer extends E
* @deprecated (4.3) use {@link SharedInputBuffer#SharedInputBuffer(int, ByteBufferAllocator)}
*/
@Deprecated
- public SharedInputBuffer(int buffersize, final IOControl ioctrl, final ByteBufferAllocator allocator) {
+ public SharedInputBuffer(final int buffersize, final IOControl ioctrl, final ByteBufferAllocator allocator) {
super(buffersize, allocator);
this.ioctrl = ioctrl;
this.lock = new ReentrantLock();
@@ -75,7 +75,7 @@ public class SharedInputBuffer extends E
/**
* @since 4.3
*/
- public SharedInputBuffer(int buffersize, final ByteBufferAllocator allocator) {
+ public SharedInputBuffer(final int buffersize, final ByteBufferAllocator allocator) {
super(buffersize, allocator);
this.lock = new ReentrantLock();
this.condition = this.lock.newCondition();
@@ -84,7 +84,7 @@ public class SharedInputBuffer extends E
/**
* @since 4.3
*/
- public SharedInputBuffer(int buffersize) {
+ public SharedInputBuffer(final int buffersize) {
this(buffersize, HeapByteBufferAllocator.INSTANCE);
}
@@ -264,7 +264,7 @@ public class SharedInputBuffer extends E
}
}
- public int read(final byte[] b, int off, int len) throws IOException {
+ public int read(final byte[] b, final int off, final int len) throws IOException {
if (this.shutdown) {
return -1;
}
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java Tue Jan 15 18:29:58 2013
@@ -67,7 +67,7 @@ public class SharedOutputBuffer extends
* @deprecated (4.3) use {@link SharedOutputBuffer#SharedOutputBuffer(int, ByteBufferAllocator)}
*/
@Deprecated
- public SharedOutputBuffer(int buffersize, final IOControl ioctrl, final ByteBufferAllocator allocator) {
+ public SharedOutputBuffer(final int buffersize, final IOControl ioctrl, final ByteBufferAllocator allocator) {
super(buffersize, allocator);
Args.notNull(ioctrl, "I/O content control");
this.ioctrl = ioctrl;
@@ -78,7 +78,7 @@ public class SharedOutputBuffer extends
/**
* @since 4.3
*/
- public SharedOutputBuffer(int buffersize, final ByteBufferAllocator allocator) {
+ public SharedOutputBuffer(final int buffersize, final ByteBufferAllocator allocator) {
super(buffersize, allocator);
this.lock = new ReentrantLock();
this.condition = this.lock.newCondition();
@@ -87,7 +87,7 @@ public class SharedOutputBuffer extends
/**
* @since 4.3
*/
- public SharedOutputBuffer(int buffersize) {
+ public SharedOutputBuffer(final int buffersize) {
this(buffersize, HeapByteBufferAllocator.INSTANCE);
}
@@ -209,7 +209,7 @@ public class SharedOutputBuffer extends
}
}
- public void write(final byte[] b, int off, int len) throws IOException {
+ public void write(final byte[] b, int off, final int len) throws IOException {
if (b == null) {
return;
}
@@ -240,7 +240,7 @@ public class SharedOutputBuffer extends
write(b, 0, b.length);
}
- public void write(int b) throws IOException {
+ public void write(final int b) throws IOException {
this.lock.lock();
try {
Asserts.check(!this.shutdown && !this.endOfStream, "Buffer already closed for writing");
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SimpleInputBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SimpleInputBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SimpleInputBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/util/SimpleInputBuffer.java Tue Jan 15 18:29:58 2013
@@ -43,14 +43,14 @@ public class SimpleInputBuffer extends E
private boolean endOfStream = false;
- public SimpleInputBuffer(int buffersize, final ByteBufferAllocator allocator) {
+ public SimpleInputBuffer(final int buffersize, final ByteBufferAllocator allocator) {
super(buffersize, allocator);
}
/**
* @since 4.3
*/
- public SimpleInputBuffer(int buffersize) {
+ public SimpleInputBuffer(final int buffersize) {
this(buffersize, HeapByteBufferAllocator.INSTANCE);
}
@@ -92,7 +92,7 @@ public class SimpleInputBuffer extends E
return this.buffer.get() & 0xff;
}
- public int read(final byte[] b, int off, int len) throws IOException {
+ public int read(final byte[] b, final int off, final int len) throws IOException {
if (isEndOfStream()) {
return -1;
}