You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/15 17:53:52 UTC

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24853


Change subject: IMPALA-13938: Update Java deps
......................................................................

IMPALA-13938: Update Java deps

Update Java dependencies that required Java 17, and others to their
latest bug fix version.

Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 16 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/24853/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14045/


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 22:57:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................

IMPALA-13938: Update Java deps

Update Java dependencies that required Java 17, and others to their
latest bug fix version.

Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Reviewed-on: http://gerrit.cloudera.org:8080/24853
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Csaba Ringhofer: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24853/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/24853/1/bin/impala-config.sh@282
PS1, Line 282: export IMPALA_BOUNCY_CASTLE_VERSION=1.80
Bouncycastle's actually up to 1.86. I'm doing another round of review on versions we could update to.



-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 19:00:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14045/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 18:21:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 3: Code-Review+2

> > Patch Set 1: Verified-1
 > >
 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14045/
 > 
 > Something in datasketches 6.1 or 6.2 changed, causing a Puffin test
 > to fail. I'm not going to try to diagnose it, just omitted that
 > change.

ack, it would be nice to investigate this in a separate patch - the issue seems leaving ndv -1 in some case, which is worrying if there was no error earlier


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 07:57:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 01:37:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24853

to look at the new patch set (#3).

Change subject: IMPALA-13938: Update Java deps
......................................................................

IMPALA-13938: Update Java deps

Update Java dependencies that required Java 17, and others to their
latest bug fix version.

Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/24853/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24040/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 19:30:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 2:

> Patch Set 1: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14045/

Something in datasketches 6.1 or 6.2 changed, causing a Puffin test to fail. I'm not going to try to diagnose it, just omitted that change.


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 21:05:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14060/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 21:05:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24038/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 18:17:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24060/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 21:29:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24853

to look at the new patch set (#2).

Change subject: IMPALA-13938: Update Java deps
......................................................................

IMPALA-13938: Update Java deps

Update Java dependencies that required Java 17, and others to their
latest bug fix version.

Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 16 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/24853/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13938: Update Java deps

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24853 )

Change subject: IMPALA-13938: Update Java deps
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic115b08037d9948c8840796c1eb19c78be1b2b44
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 18:52:21 +0000
Gerrit-HasComments: No