[jira] [Created] (LIBCLOUD-664) EC2 driver breaks contract with base driver in `list_volume_snapshots`

["Henk Slaaf (JIRA)" <ji...@apache.org>]

Henk Slaaf created LIBCLOUD-664:
-----------------------------------

             Summary: EC2 driver breaks contract with base driver in `list_volume_snapshots`
                 Key: LIBCLOUD-664
                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-664
             Project: Libcloud
          Issue Type: Bug
            Reporter: Henk Slaaf
            Priority: Minor


The base driver has the following definition for `list_volume_snapshots`:

{code}
def list_volume_snapshots(self, volume):
        """
        List snapshots for a storage volume.
        
        :rtype: ``list`` of :class:`VolumeSnapshot`
        """
        raise NotImplementedError(
            'list_volume_snapshots not implemented for this driver')
{code}

This function is volume-centric and should return all snapshots for the given Volume.

In contrast, EC2 has the following, which is snapshot-centric and returns only the given snapshot.

{code}
    def list_volume_snapshots(self, snapshot):
        return self.list_snapshots(snapshot)
{code}

We should change this to both be volume-centric. In its current form, this function is identical to list_snapshots and thus redundant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)