You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/10/03 07:53:08 UTC
Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1562
https://issues.apache.org/jira/browse/SQOOP-1562
Repository: sqoop-SQOOP-1367
Description
-------
commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 2 02:35:50 2014 -0700
SQOOP-1562: Sqoop2: BIT handling in CSV IDF
:100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
:100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
Diffs
-----
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 765bedd
Diff: https://reviews.apache.org/r/26310/diff/
Testing
-------
mvn clean test
'mvn clean verify' may not succeed without SQOOP-1561.
Thanks,
Abraham Elmahrek
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/#review55341
-----------------------------------------------------------
Ship it!
Ship It!
- Veena Basavaraj
On Oct. 2, 2014, 10:53 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26310/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 10:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1562
> https://issues.apache.org/jira/browse/SQOOP-1562
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 2 02:35:50 2014 -0700
>
> SQOOP-1562: Sqoop2: BIT handling in CSV IDF
>
> :100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 765bedd
>
> Diff: https://reviews.apache.org/r/26310/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> 'mvn clean verify' may not succeed without SQOOP-1561.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Jarek Cecho <ja...@apache.org>.
> On Oct. 3, 2014, 2:34 p.m., Jarek Cecho wrote:
> > The patch no longer applies, could you rebase it Abe?
>
> Abraham Elmahrek wrote:
> I've rebased the patch. It's available on the Jira. Thank you Jarcec!
And it again won't apply because I've committed SQOOP-1561 - could you rebase one last time? :)
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/#review55342
-----------------------------------------------------------
On Oct. 3, 2014, 6:54 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26310/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 6:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1562
> https://issues.apache.org/jira/browse/SQOOP-1562
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 2 02:35:50 2014 -0700
>
> SQOOP-1562: Sqoop2: BIT handling in CSV IDF
>
> :100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
>
> Diff: https://reviews.apache.org/r/26310/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> 'mvn clean verify' may not succeed without SQOOP-1561.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 3, 2014, 2:34 p.m., Jarek Cecho wrote:
> > The patch no longer applies, could you rebase it Abe?
I've rebased the patch. It's available on the Jira. Thank you Jarcec!
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/#review55342
-----------------------------------------------------------
On Oct. 3, 2014, 5:53 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26310/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 5:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1562
> https://issues.apache.org/jira/browse/SQOOP-1562
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 2 02:35:50 2014 -0700
>
> SQOOP-1562: Sqoop2: BIT handling in CSV IDF
>
> :100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 765bedd
>
> Diff: https://reviews.apache.org/r/26310/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> 'mvn clean verify' may not succeed without SQOOP-1561.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/#review55342
-----------------------------------------------------------
The patch no longer applies, could you rebase it Abe?
- Jarek Cecho
On Oct. 3, 2014, 5:53 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26310/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 5:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1562
> https://issues.apache.org/jira/browse/SQOOP-1562
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 2 02:35:50 2014 -0700
>
> SQOOP-1562: Sqoop2: BIT handling in CSV IDF
>
> :100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 765bedd
>
> Diff: https://reviews.apache.org/r/26310/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> 'mvn clean verify' may not succeed without SQOOP-1561.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/#review55337
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Oct. 3, 2014, 5:53 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26310/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 5:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1562
> https://issues.apache.org/jira/browse/SQOOP-1562
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date: Thu Oct 2 02:35:50 2014 -0700
>
> SQOOP-1562: Sqoop2: BIT handling in CSV IDF
>
> :100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> :100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
>
>
> Diffs
> -----
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 765bedd
>
> Diff: https://reviews.apache.org/r/26310/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> 'mvn clean verify' may not succeed without SQOOP-1561.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 9:57 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1562
https://issues.apache.org/jira/browse/SQOOP-1562
Repository: sqoop-SQOOP-1367
Description
-------
commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 2 02:35:50 2014 -0700
SQOOP-1562: Sqoop2: BIT handling in CSV IDF
:100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
:100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
Diffs (updated)
-----
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 3c3543c
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 3159883
Diff: https://reviews.apache.org/r/26310/diff/
Testing
-------
mvn clean test
'mvn clean verify' may not succeed without SQOOP-1561.
Thanks,
Abraham Elmahrek
Re: Review Request 26310: SQOOP-1562: Sqoop2: BIT handling in CSV IDF
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26310/
-----------------------------------------------------------
(Updated Oct. 3, 2014, 6:54 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1562
https://issues.apache.org/jira/browse/SQOOP-1562
Repository: sqoop-SQOOP-1367
Description
-------
commit e612c9d44a6466ab8c838f5b6d62560d89eb78b1
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date: Thu Oct 2 02:35:50 2014 -0700
SQOOP-1562: Sqoop2: BIT handling in CSV IDF
:100644 100644 02d1a51... d0bc159... M connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
:100644 100644 765bedd... a103035... M connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
Diffs (updated)
-----
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
Diff: https://reviews.apache.org/r/26310/diff/
Testing
-------
mvn clean test
'mvn clean verify' may not succeed without SQOOP-1561.
Thanks,
Abraham Elmahrek