[jira] [Resolved] (THRIFT-3066) C++ TDenseProtocol assert modifies instead of checks

["James E. King, III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King, III resolved THRIFT-3066.
----------------------------------------
    Resolution: Fixed

> C++ TDenseProtocol assert modifies instead of checks
> ----------------------------------------------------
>
>                 Key: THRIFT-3066
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3066
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.2
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> cppcheck-1.68 found an assertion that is assigning a value:
> {noformat}  // If this is the end of the top-level write, we should have just popped
>   // the TypeSpec passed to the constructor.
>   if (ts_stack_.empty()) {
>     assert(old_tts = type_spec_);
>     return;
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)