[GitHub] [iceberg] rdblue commented on a diff in pull request #5812: Use Java collections in AwsProperties to fix Kryo serialization.

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5812:
URL: https://github.com/apache/iceberg/pull/5812#discussion_r975902776


##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsProperties.java:
##########
@@ -204,4 +206,21 @@ public void testS3FileIoSessionCredentialsConfiguration() {
         "secret",
         capturedAwsCredentialsProvider.resolveCredentials().secretAccessKey());
   }
+
+  @Test
+  public void testKryoSerialization() throws IOException {

Review Comment:
   Can you also add a test for S3FileIO or whatever was causing this to get serialized? I think we must be missing a test for that as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org