You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "linzihao1999 (via GitHub)" <gi...@apache.org> on 2023/12/18 12:10:46 UTC
[PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
linzihao1999 opened a new pull request, #15038:
URL: https://github.com/apache/kafka/pull/15038
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2131300855
@linzihao1999 No worries. It's not really urgent but it would be nice to get it done in the next month or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2041800868
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2117661783
@linzihao1999 Can you follow up this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison closed pull request #15038: KAFKA-15746: KRaft support in ControllerMutationQuotaTest
URL: https://github.com/apache/kafka/pull/15038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #15038:
URL: https://github.com/apache/kafka/pull/15038#discussion_r1444747617
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -139,20 +143,23 @@ class ControllerMutationQuotaTest extends BaseRequestTest {
val (_, errors) = createTopics(Map("topic" -> 1), StrictDeleteTopicsRequestVersion)
assertEquals(Set(Errors.NONE), errors.values.toSet)
- // Metric must be there with the correct config
- waitQuotaMetric(principal.getName, ControllerMutationRate)
+ if (!isKRaftTest()) {
Review Comment:
Why are we only doing these checks in ZK mode? Isn't the controller mutation quota also working in KRaft mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2258437956
Done in https://github.com/apache/kafka/pull/16620. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2044622032
@linzihao1999 Are you planning to address the review comments? Let us know if you have issues. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]
Posted by "linzihao1999 (via GitHub)" <gi...@apache.org>.
linzihao1999 commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2130704304
@mimaison Sorry for stale this issue, i can follow it. If your has another arrangement, fell free to take over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org