[GitHub] airavata issue #54: Adding SSH Credential summary data model

[shamrath <gi...@git.apache.org>]

Github user shamrath commented on the issue:

    https://github.com/apache/airavata/pull/54
  
    Hi Anuj 
    
    Followings are few suggestions to improve your pull request. 
    
    1. We can do this in a better way by adding generic API method(to AiravataAPIServer) like "getAllCredentialSummary" instead of adding API method for each credential types eg: "getAllGatewaySSHPubKeysSummary" which will return all the credential summary for that particular gatewayId. You may be able to remove few redundant methods from Airavata API server.
    2. Let's introduced one credential summary struct to all credential types, how we differentiate is we have credential type enum field( SSH, PASSWD, CERT etc ) in the credential summary thrift struct. 
    3. Move credential data model thrift file to data model directory and merge credential summary thrift file with it. 
    4. Credential stubs still have date fields in generated thrift files, not because your changes, but we need to fix it so remove it. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---