You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/21 10:47:02 UTC

[GitHub] [doris] hf200012 opened a new pull request, #11081: [improvement]Remove the website build framework from the docs directory

hf200012 opened a new pull request, #11081:
URL: https://github.com/apache/doris/pull/11081

   # Proposed changes
   
   Issue Number: close #11080
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11081: [improvement]Remove the website build framework from the docs directory

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11081:
URL: https://github.com/apache/doris/pull/11081#issuecomment-1196417013

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11081: [improvement]Remove the website build framework from the docs directory

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11081:
URL: https://github.com/apache/doris/pull/11081#issuecomment-1196416966

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hf200012 merged pull request #11081: [improvement]Remove the website build framework from the docs directory

Posted by GitBox <gi...@apache.org>.
hf200012 merged PR #11081:
URL: https://github.com/apache/doris/pull/11081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman commented on a diff in pull request #11081: [improvement]Remove the website build framework from the docs directory

Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #11081:
URL: https://github.com/apache/doris/pull/11081#discussion_r926670797


##########
.github/workflows/build-extension.yml:
##########
@@ -54,8 +54,3 @@ jobs:
     - name: Build broker
       run: |
         cd fs_brokers/apache_hdfs_broker/ && /bin/bash build.sh
-
-    - name: Build docs
-      run: |
-        cd docs &&  /bin/bash build_help_zip.sh && export NODE_OPTIONS="--max-old-space-size=8192" && npm install && npm run build

Review Comment:
   we still need `build_help_zip.sh`



##########
docs/.vuepress/sidebar/en/docs.js:
##########
@@ -1,1014 +0,0 @@
-/*

Review Comment:
   I think we still need this sidebar?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hf200012 commented on a diff in pull request #11081: [improvement]Remove the website build framework from the docs directory

Posted by GitBox <gi...@apache.org>.
hf200012 commented on code in PR #11081:
URL: https://github.com/apache/doris/pull/11081#discussion_r927215988


##########
docs/.vuepress/sidebar/en/docs.js:
##########
@@ -1,1014 +0,0 @@
-/*

Review Comment:
   solved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org