You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/14 20:22:08 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3653: ARTEMIS-3385 management changes can be reverted by XML update
jbertram opened a new pull request #3653:
URL: https://github.com/apache/activemq-artemis/pull/3653
Durable changes made via the management API (e.g. adding
security-settings, adding address-settings, adding diverts) can be
reverted when reloading the XML at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3653: ARTEMIS-3385 management changes can be reverted by XML update
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3653:
URL: https://github.com/apache/activemq-artemis/pull/3653#discussion_r681922878
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
##########
@@ -197,6 +197,237 @@ public void run() {
}
}
+ @Test
+ public void testRedeploySecuritySettings() throws Exception {
+ Path brokerXML = getTestDirfile().toPath().resolve("broker.xml");
+ URL url1 = RedeployTest.class.getClassLoader().getResource("reload-security-settings.xml");
+ URL url2 = RedeployTest.class.getClassLoader().getResource("reload-security-settings-updated.xml");
+ Files.copy(url1.openStream(), brokerXML);
+
+ EmbeddedActiveMQ embeddedActiveMQ = new EmbeddedActiveMQ();
+ embeddedActiveMQ.setConfigResourcePath(brokerXML.toUri().toString());
+ embeddedActiveMQ.start();
+
+ final ReusableLatch latch = new ReusableLatch(1);
+
+ Runnable tick = new Runnable() {
+ @Override
+ public void run() {
+ latch.countDown();
+ }
+ };
+
+ embeddedActiveMQ.getActiveMQServer().getReloadManager().setTick(tick);
Review comment:
never mind.. all the other tests are doing the same.. it's just a copy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3653: ARTEMIS-3385 management changes can be reverted by XML update
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3653:
URL: https://github.com/apache/activemq-artemis/pull/3653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3653: ARTEMIS-3385 management changes can be reverted by XML update
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3653:
URL: https://github.com/apache/activemq-artemis/pull/3653#discussion_r681807480
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
##########
@@ -197,6 +197,237 @@ public void run() {
}
}
+ @Test
+ public void testRedeploySecuritySettings() throws Exception {
+ Path brokerXML = getTestDirfile().toPath().resolve("broker.xml");
+ URL url1 = RedeployTest.class.getClassLoader().getResource("reload-security-settings.xml");
+ URL url2 = RedeployTest.class.getClassLoader().getResource("reload-security-settings-updated.xml");
+ Files.copy(url1.openStream(), brokerXML);
+
+ EmbeddedActiveMQ embeddedActiveMQ = new EmbeddedActiveMQ();
+ embeddedActiveMQ.setConfigResourcePath(brokerXML.toUri().toString());
+ embeddedActiveMQ.start();
+
+ final ReusableLatch latch = new ReusableLatch(1);
+
+ Runnable tick = new Runnable() {
+ @Override
+ public void run() {
+ latch.countDown();
+ }
+ };
+
+ embeddedActiveMQ.getActiveMQServer().getReloadManager().setTick(tick);
Review comment:
setTick(latch::countDown) would been nicer.. no need to make the change though as it's just a test. (just an optional comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org