You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asyncband.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2026/09/04 05:35:33 UTC
[PR] fix: preserve third-party source licensing [asyncband]
tisonkun opened a new pull request, #279:
URL: https://github.com/apache/asyncband/pull/279
## Summary
- restore upstream license and copyright treatment for third-party-derived Tokio, parking, and Fastpool source files instead of applying the standard ASF header
- document exact local-to-upstream file mappings, selected license options, and non-code design acknowledgements in `LICENSE`
- make the selected Apache-2.0 terms explicit in the extensively modified oneshot, blocking, and AtomicWaker derivatives
- exclude only the source files intentionally carrying upstream treatment from the ASF header check
## Design Notes
This applies the ASF third-party source policy per file rather than treating every attribution as a co-existing header:
- `mutex` and `rwlock` remain Tokio-derived and carry Tokio's MIT copyright/license notice plus an ASF modification note. Their source and documentation overlap is still substantial enough that this PR does not reclassify them as reimplementations.
- the Fastpool-derived pool implementation and tests restore Fastpool's original Apache-2.0 header and `Copyright 2025 FastLabs Developers`, then note the ASF modifications. This also avoids relying on sole authorship to cover Fastpool contributions.
- `blocking/parker.rs` is treated as parking-derived source. `blocking/mod.rs` retains the ASF header because only its polling loop and parker reuse strategy are adapted, while the module implementation and public contract were substantially developed in Asyncband.
- oneshot and AtomicWaker retain their ASF headers because their current files contain extensive Asyncband modifications, but continue to identify the incorporated upstream work and its selected Apache-2.0 terms. This is the highest-judgment part of the review and is intentionally visible file by file.
- `LICENSE` distinguishes incorporated source from API/design provenance, and clarifies that Fastpool is a reimplementation of Deadpool without incorporating Deadpool source.
## Validation
- `cargo x check`
- `cargo x test`
- Clippy, rustfmt, typos, Hawkeye, and rustdoc checks from `cargo x lint`
- `cargo package -p asyncband --allow-dirty --list`
Taplo 0.10.0 panics locally while initializing the macOS system proxy configuration, before formatting any file; `licenserc.toml` was checked against the repository's two-space Taplo configuration and CI will run the formatter independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org
Re: [PR] fix: preserve third-party source licensing [asyncband]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #279:
URL: https://github.com/apache/asyncband/pull/279#discussion_r3931642508
##########
CHANGELOG.md:
##########
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
## Unreleased
+### Bug fixes
Review Comment:
```suggestion
### Improvements
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org
Re: [PR] fix: preserve third-party source licensing [asyncband]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #279:
URL: https://github.com/apache/asyncband/pull/279#issuecomment-5537076779
> Broadcast retains its ASF header: its versioned shared backlog, arena-managed receiver cursors, reclamation rules, allocation policy, and WakerSet-based receive lifecycle are project-specific, while its public prose, error descriptions, cancellation explanation, and examples have been rewritten around those current contracts.
We may reimplement many of S/MPS/MC channels later and there would no longer exist these lineages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org
Re: [PR] fix: preserve third-party source licensing [asyncband]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #279:
URL: https://github.com/apache/asyncband/pull/279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@asyncband.apache.org
For additional commands, e-mail: commits-help@asyncband.apache.org