You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 11:25:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #7078: [AIRFLOW-XXXX]
Boring cyborg automatically inserts issue link
potiuk opened a new pull request #7078: [AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
URL: https://github.com/apache/airflow/pull/7078
Issue link in PR will be now automatically inserted by the boring
cyborg probot integration. It also handles the case of document-only
changes and it will keep the link updated if the title of the PR
is updated.
---
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-XXXX
- [x] Description above provides context of the change
- [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
(*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7078:
[AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7078: [AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
URL: https://github.com/apache/airflow/pull/7078#discussion_r363288028
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1,14 +1,14 @@
---
-Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-XXXX
+Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
-- [ ] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
+- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
Review comment:
You can also have INFRA-NNNN and others. So mathematically speaking "AIRFLOW-NNNN" is the ID 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7078: [AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7078: [AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
URL: https://github.com/apache/airflow/pull/7078#discussion_r363275028
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1,14 +1,14 @@
---
-Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-XXXX
+Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
-- [ ] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
+- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
Review comment:
```suggestion
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. NNNN = JIRA ID<sup>*</sup>
```
Sorry I am mathematician 🤷🏼♂️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7078: [AIRFLOW-XXXX] Boring
cyborg automatically inserts issue link
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7078: [AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
URL: https://github.com/apache/airflow/pull/7078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7078:
[AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7078: [AIRFLOW-XXXX] Boring cyborg automatically inserts issue link
URL: https://github.com/apache/airflow/pull/7078#discussion_r363287757
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1,14 +1,14 @@
---
-Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-XXXX
+Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
-- [ ] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
+- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
Review comment:
But AIRFLOW-NNNN IS the Jira ID :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services