You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/12/11 08:36:58 UTC
Review Request 28936: Set completer in CliDriver is not working
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28936/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-9077
https://issues.apache.org/jira/browse/HIVE-9077
Repository: hive-git
Description
-------
NO PRECOMMIT TESTS
Seemed broken in HIVE-8609
{noformat}
hive (default)> set Exception in thread "main" java.lang.NullPointerException
at jline.console.completer.ArgumentCompleter$AbstractArgumentDelimiter.delimit(ArgumentCompleter.java:283)
at jline.console.completer.ArgumentCompleter.complete(ArgumentCompleter.java:116)
at jline.console.completer.ArgumentCompleter.complete(ArgumentCompleter.java:152)
at org.apache.hadoop.hive.cli.CliDriver$6.complete(CliDriver.java:567)
at jline.console.ConsoleReader.complete(ConsoleReader.java:3261)
at jline.console.ConsoleReader.readLine(ConsoleReader.java:2621)
at jline.console.ConsoleReader.readLine(ConsoleReader.java:2269)
at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:714)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:639)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:578)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.main(RunJar.java:212)
{noformat}
Diffs
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java aec5018
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2e2bf5a
common/src/java/org/apache/hadoop/hive/conf/Validator.java bb0f836
Diff: https://reviews.apache.org/r/28936/diff/
Testing
-------
Thanks,
Navis Ryu
Re: Review Request 28936: Set completer in CliDriver is not working
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28936/#review64714
-----------------------------------------------------------
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/28936/#comment107513>
magic number
Thank Navis for your good catch and patch. I tested it locally and worked well for the auto-complete of hive configurations. LGTM despite one minor issue.
- cheng xu
On Dec. 11, 2014, 7:36 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28936/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 7:36 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-9077
> https://issues.apache.org/jira/browse/HIVE-9077
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> NO PRECOMMIT TESTS
>
> Seemed broken in HIVE-8609
> {noformat}
> hive (default)> set Exception in thread "main" java.lang.NullPointerException
> at jline.console.completer.ArgumentCompleter$AbstractArgumentDelimiter.delimit(ArgumentCompleter.java:283)
> at jline.console.completer.ArgumentCompleter.complete(ArgumentCompleter.java:116)
> at jline.console.completer.ArgumentCompleter.complete(ArgumentCompleter.java:152)
> at org.apache.hadoop.hive.cli.CliDriver$6.complete(CliDriver.java:567)
> at jline.console.ConsoleReader.complete(ConsoleReader.java:3261)
> at jline.console.ConsoleReader.readLine(ConsoleReader.java:2621)
> at jline.console.ConsoleReader.readLine(ConsoleReader.java:2269)
> at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:714)
> at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:639)
> at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:578)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:212)
> {noformat}
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java aec5018
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2e2bf5a
> common/src/java/org/apache/hadoop/hive/conf/Validator.java bb0f836
>
> Diff: https://reviews.apache.org/r/28936/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 28936: Set completer in CliDriver is not working
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28936/#review64845
-----------------------------------------------------------
Ship it!
Looks great! As Ferdinand says I think we can make that 10 a constant and then commit. Please upload the updated patch to the JIRA, no need to update here.
Thanks!!
- Brock Noland
On Dec. 11, 2014, 7:36 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28936/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 7:36 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-9077
> https://issues.apache.org/jira/browse/HIVE-9077
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> NO PRECOMMIT TESTS
>
> Seemed broken in HIVE-8609
> {noformat}
> hive (default)> set Exception in thread "main" java.lang.NullPointerException
> at jline.console.completer.ArgumentCompleter$AbstractArgumentDelimiter.delimit(ArgumentCompleter.java:283)
> at jline.console.completer.ArgumentCompleter.complete(ArgumentCompleter.java:116)
> at jline.console.completer.ArgumentCompleter.complete(ArgumentCompleter.java:152)
> at org.apache.hadoop.hive.cli.CliDriver$6.complete(CliDriver.java:567)
> at jline.console.ConsoleReader.complete(ConsoleReader.java:3261)
> at jline.console.ConsoleReader.readLine(ConsoleReader.java:2621)
> at jline.console.ConsoleReader.readLine(ConsoleReader.java:2269)
> at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:714)
> at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:639)
> at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:578)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:212)
> {noformat}
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java aec5018
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2e2bf5a
> common/src/java/org/apache/hadoop/hive/conf/Validator.java bb0f836
>
> Diff: https://reviews.apache.org/r/28936/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>