You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lukasz Strzelecki (JIRA)" <ji...@codehaus.org> on 2013/02/23 13:39:52 UTC

[jira] (MRELEASE-826) preparationGoals and git

Lukasz Strzelecki created MRELEASE-826:
------------------------------------------

             Summary: preparationGoals and git
                 Key: MRELEASE-826
                 URL: https://jira.codehaus.org/browse/MRELEASE-826
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
          Components: Git, prepare
    Affects Versions: 2.4
         Environment: Apache Maven 3.0.4
Java version: 1.6.0_37, vendor: Sun Microsystems Inc.
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.5.0-21-generic", arch: "amd64", family: "unix"
            Reporter: Lukasz Strzelecki


* What I want achieve?
Before release:prepare process I want change source. Filter some source file and put release version X.Y.Z (without SNAPSHOT)

So I configured release plugin with
<preparationGoals>android:manifest-update</preparationGoals>

Goal: android:manifest-update change AndroidManifest.xml

I suppose this change should be applied AFTER change version without SNAPSHOT and BEFORE commit changes to git repository.

I see that goal is executed and valid version is propagated. But when I read log for commit/push commands I see:

{code}
[INFO] Not removing release POMs
[INFO] Checking in modified POMs...
[INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && git add -- pom.xml
[INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
[INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && git status --porcelain
[INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
[INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && git commit --verbose -F /tmp/maven-scm-1669056864.commit pom.xml
[INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
[INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && git symbolic-ref HEAD
[INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
[INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && git push git@github.com:lstrzelecki/poc-android-release.git master:master
[INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
[INFO] Release preparation complete.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
{code} 

I think what is missing is that we add ONLY pom.xml
See this line:

Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && *git add -- pom.xml*

What I expect that plugin should add all files (by ie git add .) 

If you want some example you can fork github project:
https://github.com/lstrzelecki/poc-android-release

It requires android SDK.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira