You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/03 17:08:51 UTC

[GitHub] larroy closed pull request #12238: [WIP][Don't merge][Don't review] use jom

larroy closed pull request #12238: [WIP][Don't merge][Don't review] use jom
URL: https://github.com/apache/incubator-mxnet/pull/12238
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ci/build_windows.py b/ci/build_windows.py
index 5eca58db7b7..787f0511688 100755
--- a/ci/build_windows.py
+++ b/ci/build_windows.py
@@ -146,10 +146,11 @@ def windows_build(args):
     with remember_cwd():
         os.chdir(path)
         logging.info("Generating project with CMake")
-        check_call("cmake -G \"Visual Studio 14 2015 Win64\" {} {}".format(CMAKE_FLAGS[args.flavour], mxnet_root), shell=True)
+        check_call("cmake -G \"NMake Makefiles JOM\" {} {}".format(CMAKE_FLAGS[args.flavour], mxnet_root), shell=True)
         logging.info("Building with visual studio")
         t0 = int(time.time())
-        check_call(["msbuild", "mxnet.sln","/p:configuration=release;platform=x64", "/maxcpucount","/v:minimal"])
+        #check_call(["msbuild", "mxnet.sln","/p:configuration=release;platform=x64", "/maxcpucount","/v:minimal"])
+        check_call(["jom"])
         logging.info("Build flavour: %s complete in directory: \"%s\"", args.flavour, os.path.abspath(path))
         logging.info("Build took %s" , datetime.timedelta(seconds=int(time.time()-t0)))
     windows_package(args)


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services