You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/02/17 06:20:24 UTC
[GitHub] [hive] amanraj2520 opened a new pull request, #4068: HIVE-27089 : Test fixes for orc_merge*.q
amanraj2520 opened a new pull request, #4068:
URL: https://github.com/apache/hive/pull/4068
JIRA link : https://issues.apache.org/jira/browse/HIVE-27089
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1435160748
Thanks @yigress for the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1460040365
@yigress I am not sure if it is LLAP related. If you check the `orc_merge1.q` file there are three `dfs -ls` operations always following an `INSERT OVERWRITE TABLE` query. I assume that the `OVERWRITE` query rewrites the directory every time.
Before HIVE-27016:
```
INSERT OVERWRITE TABLE
dfs -ls
-rw-r--r--
INSERT OVERWRITE TABLE
dfs -ls
-rw-rw-rw-
INSERT OVERWRITE TABLE
dfs -ls
-rw-rw-rw-
```
After HIVE-27016:
```
INSERT OVERWRITE TABLE
dfs -ls
-rw-rw-rw-
INSERT OVERWRITE TABLE
dfs -ls
-rw-rw-rw-
INSERT OVERWRITE TABLE
dfs -ls
-rw-rw-rw-
```
Worth mentioning that even before HIVE-27016 we have directories created with `-rw-rw-rw-` just not the first time.
There must be a code-path that operates with different permissions and this is definitely a bug. If someone can pinpoint the exact reason of why this happens and raise a JIRA that would be great.
However, given that permission differences existed even before HIVE-27016, I will not consider HIVE-27016 as a regression so I am OK to simply update the .q.out files for the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1435135855
@zabetak @abstractdog Can you please review and merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1456758991
@zabetak this seems to be file permission differences in llap and non-llap setup. If you think it better to revert HIVE-27016 first to unblock tests, I am fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
URL: https://github.com/apache/hive/pull/4068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1434816579
@zabetak I think it is either of this PR - https://github.com/apache/hive/pull/4046 or https://github.com/apache/hive/pull/4014.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1436739109
@zabetak @abstractdog Can you please review and merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1454834678
@zabetak Can you please suggest what should be done for these test fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1434493180
@amanraj2520 Thanks for the patch. Any ideas which commit broke these tests? Can you link the respective JIRA tickets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1435041562
@zabetak @amanraj2520 I wonder if we should continue with this fix, rather than revert HIVE-27016? The reason is that I see in branch-4 the permissions were changed as proposed here in HIVE-22589, but it is not apparent to me that HIVE-22589 itself causes the permission changes, so it looks like the orc_merge* tests permissions should have been updated.
I agree that stabilizing the tests is the first priority in branch-3 right now. Our users looking forward to the next branch-3 release as branch-4 seems a bit too far, this feature is very important for users who are staying on branch-3 with storagehandlers. We will watch branch-3 progress and not making addons until tests are stabilized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1461074375
@zabetak thank you for taking time detailed analysis!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1434921476
@zabetak @abstractdog Please ignore my above message. I found the commit that caused this failure. I have reverted that commit and tested it. This is the commit that brought the failure - HIVE-27016 . Pull request - https://github.com/apache/hive/pull/4013. On reverting I can see -rw getting replaced by -r--
This has run in my local so its USER is different.
@sunchao @yigress Is the fix I did an expected behaviour as a result of this commit or does there need to be a change in this https://github.com/apache/hive/pull/4013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1441619183
@zabetak Can you suggest what according to you is the right approach to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1438203527
@zabetak Not sure about the reason. But will investigate. @yigress @sunchao Can you please check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1434325920
@zabetak @abstractdog Can you please approve and merge this. All other failures are intermittent or existing issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4068: HIVE-27089 : Test fixes for orc_merge*.q
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4068:
URL: https://github.com/apache/hive/pull/4068#issuecomment-1439012689
Thank you @zabetak for pointing to the correct HIVE-21305 that changed permissions for the test files. HIVE-21305 suggests that with IO cache and without IO cache the file permissions will be different, so that gives the impression that in LLAP the permissions is not really an issue?
I tested this with non-LLAP hive, there is no permissions change before or after HIVE-27016. As HIVE-27016 invokes Outputcommitter on Tez-AM, so my guess is that in LLAP it causes file write (in these orc file tests) with the changed permissions, however in non-LLAP this only affects storagehandler type tables so the output permissions for orc tables remain unchanged.
This calls for difference of outputs file permissions in LLAP and non-LLAP, wonder has this been discussed before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org