[GitHub] [hive] jcamachor commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #1443:
URL: https://github.com/apache/hive/pull/1443#discussion_r481291877



##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
##########
@@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type) throws SQLException {
     Utils.verifySuccess(resp.getStatus());
     return resp;
   }
+
+  private boolean getHiveDefaultNullsLast() {
+    boolean response = ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;

Review comment:
       I think @thejasmn concern is valid. If user specifies the property value in the connection parameters, then we will retrieve it here. However, if it is not present, we probably need to establish a connection to HS2 to retrieve the parameter value, since it may not be necessarily the default?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org