[GitHub] [superset] zhaoyongjie commented on pull request #19366: fix: can't sync temporal flag on virtual table

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #19366:
URL: https://github.com/apache/superset/pull/19366#issuecomment-1085609551


   > Love it, thanks for this fix + nice cleanup! In the long run I feel we should start moving types from `superset/superset_typing.py` into the packages where they are most relevant (see e.g. `superset/key_value/types.py`), but that can be done in a follow up (e.g. the one planned for physical columns)
   
   sounds good! I will follow this pattern in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org