You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 01:18:49 UTC
[GitHub] [incubator-superset] rusackas commented on pull request #10933: ESLint: Remove ts-ignore comments
rusackas commented on pull request #10933:
URL: https://github.com/apache/incubator-superset/pull/10933#issuecomment-696462865
```
2020-09-21T22:49:21.6155663Z > eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx . && npm run type
2020-09-21T22:49:21.6156105Z
2020-09-21T22:50:19.3926195Z
2020-09-21T22:50:19.3929001Z /home/runner/work/incubator-superset/incubator-superset/superset-frontend/spec/javascripts/components/TableSelector_spec.jsx
2020-09-21T22:50:19.3930832Z 179:5 warning Skipped test jest/no-disabled-tests
2020-09-21T22:50:19.3932051Z 221:5 warning Skipped test jest/no-disabled-tests
2020-09-21T22:50:19.3932744Z
2020-09-21T22:50:19.3934154Z /home/runner/work/incubator-superset/incubator-superset/superset-frontend/spec/javascripts/explore/utils_spec.jsx
2020-09-21T22:50:19.3935922Z 59:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3939217Z 68:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3940312Z 80:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3941191Z 92:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3942061Z 104:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3942930Z 116:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3943799Z 195:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3944281Z
2020-09-21T22:50:19.3945490Z /home/runner/work/incubator-superset/incubator-superset/superset-frontend/spec/javascripts/sqllab/TableElement_spec.jsx
2020-09-21T22:50:19.3946832Z 52:3 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3947260Z
2020-09-21T22:50:19.3948419Z /home/runner/work/incubator-superset/incubator-superset/superset-frontend/spec/javascripts/sqllab/actions/sqlLab_spec.js
2020-09-21T22:50:19.3949738Z 110:5 warning Skipped test jest/no-disabled-tests
2020-09-21T22:50:19.3950579Z 178:5 warning Skipped test jest/no-disabled-tests
2020-09-21T22:50:19.3950980Z
2020-09-21T22:50:19.3952147Z /home/runner/work/incubator-superset/incubator-superset/superset-frontend/spec/javascripts/sqllab/reducers/sqlLab_spec.js
2020-09-21T22:50:19.3953464Z 247:5 warning Test has no assertions jest/expect-expect
2020-09-21T22:50:19.3953857Z
2020-09-21T22:50:19.3955078Z /home/runner/work/incubator-superset/incubator-superset/superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
2020-09-21T22:50:19.3956720Z 31:3 warning 'addDangerToast' is defined but never used @typescript-eslint/no-unused-vars
2020-09-21T22:50:19.3958073Z 32:3 warning 'addSuccessToast' is defined but never used @typescript-eslint/no-unused-vars
2020-09-21T22:50:19.3958698Z
2020-09-21T22:50:19.3959246Z ✖ 15 problems (0 errors, 15 warnings)
2020-09-21T22:50:19.3959572Z
2020-09-21T22:50:20.2057788Z
2020-09-21T22:50:20.2059601Z > superset@0.999.0-dev type /home/runner/work/incubator-superset/incubator-superset/superset-frontend
2020-09-21T22:50:20.2060451Z > tsc --noEmit
2020-09-21T22:50:20.2060663Z
2020-09-21T22:50:44.1527383Z [96msrc/components/ListView/Filters.tsx[0m:[93m140[0m:[93m11[0m - [91merror[0m[90m TS2322: [0mType '{ label: string; value: string; }' is not assignable to type 'ValueType<GroupType<GroupType<never>>>'.
2020-09-21T22:50:44.1529417Z Property 'options' is missing in type '{ label: string; value: string; }' but required in type 'GroupType<GroupType<never>>'.
2020-09-21T22:50:44.1530168Z
2020-09-21T22:50:44.1530855Z [7m140[0m value={selectedOption}
2020-09-21T22:50:44.1531543Z [7m [0m [91m ~~~~~[0m
2020-09-21T22:50:44.1531916Z
2020-09-21T22:50:44.1533246Z [96mnode_modules/@types/react-select/src/types.d.ts[0m:[93m11[0m:[93m3[0m
2020-09-21T22:50:44.1534417Z [7m11[0m options: OptionsType<OptionType>;
2020-09-21T22:50:44.1537461Z [7m [0m [96m ~~~~~~~[0m
2020-09-21T22:50:44.1538732Z 'options' is declared here.
2020-09-21T22:50:44.1539523Z [96mnode_modules/@types/react-select/src/Select.d.ts[0m:[93m205[0m:[93m3[0m
2020-09-21T22:50:44.1540192Z [7m205[0m value?: ValueType<OptionType>;
2020-09-21T22:50:44.1540648Z [7m [0m [96m ~~~~~[0m
2020-09-21T22:50:44.1541964Z The expected type comes from property 'value' which is declared here on type 'IntrinsicAttributes & Props<GroupType<GroupType<never>>> & UseAsyncPaginateParams<GroupType<GroupType<never>>, any> & ComponentProps & { ...; } & { ...; }'
2020-09-21T22:50:44.1542896Z
2020-09-21T22:50:44.1544256Z [96msrc/components/ListView/Filters.tsx[0m:[93m141[0m:[93m11[0m - [91merror[0m[90m TS2322: [0mType '(selected: SelectOption | null) => void' is not assignable to type '(value: ValueType<GroupType<GroupType<never>>>, action: ActionMeta<GroupType<GroupType<never>>>) => void'.
2020-09-21T22:50:44.1545588Z Types of parameters 'selected' and 'value' are incompatible.
2020-09-21T22:50:44.1546437Z Type 'ValueType<GroupType<GroupType<never>>>' is not assignable to type 'SelectOption | null'.
2020-09-21T22:50:44.1547291Z Type 'undefined' is not assignable to type 'SelectOption | null'.
2020-09-21T22:50:44.1547649Z
2020-09-21T22:50:44.1548063Z [7m141[0m onChange={onChange}
2020-09-21T22:50:44.1548491Z [7m [0m [91m ~~~~~~~~[0m
2020-09-21T22:50:44.1548650Z
2020-09-21T22:50:44.1549206Z [96mnode_modules/@types/react-select/src/Select.d.ts[0m:[93m169[0m:[93m3[0m
2020-09-21T22:50:44.1550056Z [7m169[0m onChange?: (value: ValueType<OptionType>, action: ActionMeta<OptionType>) => void;
2020-09-21T22:50:44.1550753Z [7m [0m [96m ~~~~~~~~[0m
2020-09-21T22:50:44.1551913Z The expected type comes from property 'onChange' which is declared here on type 'IntrinsicAttributes & Props<GroupType<GroupType<never>>> & UseAsyncPaginateParams<GroupType<GroupType<never>>, any> & ComponentProps & { ...; } & { ...; }'
2020-09-21T22:50:44.1552741Z
2020-09-21T22:50:44.1554123Z [96msrc/components/ListView/Filters.tsx[0m:[93m142[0m:[93m11[0m - [91merror[0m[90m TS2322: [0mType '(inputValue: string, loadedOptions: SelectOption[], { page }: { page: number; }) => Promise<{ options: { label: string; value: string; }[]; hasMore: boolean; additional: { page: number; }; }>' is not assignable to type 'LoadOptions<GroupType<GroupType<never>>, any>'.
2020-09-21T22:50:44.1555467Z Types of parameters 'loadedOptions' and 'options' are incompatible.
2020-09-21T22:50:44.1556260Z Type 'OptionsList<GroupType<GroupType<never>>>' is not assignable to type 'SelectOption[]'.
2020-09-21T22:50:44.1557211Z The type 'OptionsType<GroupType<GroupType<never>>>' is 'readonly' and cannot be assigned to the mutable type 'SelectOption[]'.
2020-09-21T22:50:44.1557691Z
2020-09-21T22:50:44.1558183Z [7m142[0m loadOptions={fetchAndFormatSelects}
2020-09-21T22:50:44.1558686Z [7m [0m [91m ~~~~~~~~~~~[0m
2020-09-21T22:50:44.1558828Z
2020-09-21T22:50:44.1559425Z [96mnode_modules/react-select-async-paginate/ts/types.d.ts[0m:[93m44[0m:[93m5[0m
2020-09-21T22:50:44.1560143Z [7m44[0m loadOptions: LoadOptions<OptionType>;
2020-09-21T22:50:44.1560590Z [7m [0m [96m ~~~~~~~~~~~[0m
2020-09-21T22:50:44.1561767Z The expected type comes from property 'loadOptions' which is declared here on type 'IntrinsicAttributes & Props<GroupType<GroupType<never>>> & UseAsyncPaginateParams<GroupType<GroupType<never>>, any> & ComponentProps & { ...; } & { ...; }'
2020-09-21T22:50:44.1562604Z
2020-09-21T22:50:44.1562739Z
2020-09-21T22:50:44.1562943Z Found 3 errors.
2020-09-21T22:50:44.1563099Z
2020-09-21T22:50:44.2013547Z npm ERR! code ELIFECYCLE
2020-09-21T22:50:44.2014256Z npm ERR! errno 1
2020-09-21T22:50:44.2048042Z npm ERR! superset@0.999.0-dev type: `tsc --noEmit`
2020-09-21T22:50:44.2048746Z npm ERR! Exit status 1
2020-09-21T22:50:44.2049520Z npm ERR!
2020-09-21T22:50:44.2050518Z npm ERR! Failed at the superset@0.999.0-dev type script.
2020-09-21T22:50:44.2051630Z npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
2020-09-21T22:50:44.2134011Z
2020-09-21T22:50:44.2134573Z npm ERR! A complete log of this run can be found in:
2020-09-21T22:50:44.2135568Z npm ERR! /home/runner/.npm/_logs/2020-09-21T22_50_44_204Z-debug.log
2020-09-21T22:50:44.2196844Z npm ERR! code ELIFECYCLE
2020-09-21T22:50:44.2197185Z npm ERR! errno 1
2020-09-21T22:50:44.2234404Z npm ERR! superset@0.999.0-dev lint: `eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx . && npm run type`
2020-09-21T22:50:44.2235089Z npm ERR! Exit status 1
2020-09-21T22:50:44.2235443Z npm ERR!
2020-09-21T22:50:44.2236440Z npm ERR! Failed at the superset@0.999.0-dev lint script.
2020-09-21T22:50:44.2237161Z npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
2020-09-21T22:50:44.2381461Z
2020-09-21T22:50:44.2382258Z npm ERR! A complete log of this run can be found in:
2020-09-21T22:50:44.2383564Z npm ERR! /home/runner/.npm/_logs/2020-09-21T22_50_44_223Z-debug.log
2020-09-21T22:50:44.2420245Z ##[error]Process completed with exit code 1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org